[PATCH] powerpc/powernv: Fix XSCOM address mangling for form 1 indirect

[PATCH] powerpc/powernv: Fix XSCOM address mangling for form 1 indirect

[Michael Neuling]

POWER9 adds form 1 scoms. The form of the indirection is specified in
the top nibble of the scom address.

Currently we do some (ugly) bit mangling so that we can fit a 64 bit
scom address into the debugfs interface. The current code only shifts
the top bit (indirect bit).

This patch changes it to shift the whole top nibble so that the form
of the indirection is also shifted.

This patch is backwards compatible with older scoms.

(This change isn't required in the
arch/powerpc/platformspowernv/opal-prd.c scom interface as it passes
the whole 64bit scom address without any bit mangling)

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
(resending to correct linuxppc address)

=C2=A0arch/powerpc/platforms/powernv/opal-xscom.c | 27 +++++++++++++++++---=
-------
=C2=A01 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c
b/arch/powerpc/platforms/powernv/opal-xscom.c
index d0ac535cf5..28651fb254 100644
--- a/arch/powerpc/platforms/powernv/opal-xscom.c
+++ b/arch/powerpc/platforms/powernv/opal-xscom.c
@@ -73,25 +73,32 @@ static int opal_xscom_err_xlate(int64_t rc)
=C2=A0
=C2=A0static u64 opal_scom_unmangle(u64 addr)
=C2=A0{
+	u64 tmp;
+
=C2=A0	/*
-	=C2=A0* XSCOM indirect addresses have the top bit set. Additionally
-	=C2=A0* the rest of the top 3 nibbles is always 0.
+	=C2=A0* XSCOM addresses use the top nibble to set indirect mode and
+	=C2=A0* its form.=C2=A0=C2=A0Bits 4-11 are always 0.
=C2=A0	=C2=A0*
=C2=A0	=C2=A0* Because the debugfs interface uses signed offsets and shifts
=C2=A0	=C2=A0* the address left by 3, we basically cannot use the top 4 bit=
s
=C2=A0	=C2=A0* of the 64-bit address, and thus cannot use the indirect bit.
=C2=A0	=C2=A0*
-	=C2=A0* To deal with that, we support the indirect bit being in bit
-	=C2=A0* 4 (IBM notation) instead of bit 0 in this API, we do the
-	=C2=A0* conversion here. To leave room for further xscom address
-	=C2=A0* expansion, we only clear out the top byte
+	=C2=A0* To deal with that, we support the indirect bits being in
+	=C2=A0* bits 4-7 (IBM notation) instead of bit 0-3 in this API, we
+	=C2=A0* do the conversion here.
=C2=A0	=C2=A0*
-	=C2=A0* For in-kernel use, we also support the real indirect bit, so
-	=C2=A0* we test for any of the top 5 bits
+	=C2=A0* For in-kernel use, we don't need to do this mangling.=C2=A0=C2=A0=
In
+	=C2=A0* kernel won't have bits 4-7 set.
=C2=A0	=C2=A0*
+	=C2=A0* So:
+	=C2=A0*=C2=A0=C2=A0=C2=A0debugfs will always=C2=A0=C2=A0=C2=A0set 0-3 =3D=
 0 and clear 4-7
+	=C2=A0*=C2=A0=C2=A0=C2=A0=C2=A0kernel will always clear 0-3 =3D 0 and=C2=
=A0=C2=A0=C2=A0set 4-7
=C2=A0	=C2=A0*/
-	if (addr & (0x1full << 59))
-		addr =3D (addr & ~(0xffull << 56)) | (1ull << 63);
+	tmp =3D addr;
+	tmp=C2=A0=C2=A0&=3D 0x0f00000000000000;
+	addr &=3D 0xf0ffffffffffffff;
+	addr |=3D tmp << 4;
+
=C2=A0	return addr;
=C2=A0}
=C2=A0

Re: powerpc/powernv: Fix XSCOM address mangling for form 1 indirect

[Michael Ellerman]

On Fri, 2017-03-24 at 01:43:17 UTC, Michael Neuling wrote:
> POWER9 adds form 1 scoms. The form of the indirection is specified in
> the top nibble of the scom address.
> 
> Currently we do some (ugly) bit mangling so that we can fit a 64 bit
> scom address into the debugfs interface. The current code only shifts
> the top bit (indirect bit).
> 
> This patch changes it to shift the whole top nibble so that the form
> of the indirection is also shifted.
> 
> This patch is backwards compatible with older scoms.
> 
> (This change isn't required in the
> arch/powerpc/platformspowernv/opal-prd.c scom interface as it passes
> the whole 64bit scom address without any bit mangling)
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/517c27570cf38f182e7a688d50a9b9

cheers