[PATCH] ocxl: Fix potential bad errno on irq allocation

* [PATCH] ocxl: Fix potential bad errno on irq allocation
@ 2018-02-16 13:01 Frederic Barrat
  2018-02-20 23:21 ` Andrew Donnellan
  2018-02-21 13:43 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Frederic Barrat @ 2018-02-16 13:01 UTC (permalink / raw)
  To: andrew.donnellan, linuxppc-dev; +Cc: dan.carpenter

Fix some issues found by a static checker:

When allocating an AFU interrupt, if the driver cannot copy the output
parameters to userland, the errno value was not set to EFAULT

Remove a (now) useless cast.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
---
 drivers/misc/ocxl/file.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 2dd2db9bc1c9..337462e1569f 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -133,8 +133,10 @@ static long afu_ioctl(struct file *file, unsigned int cmd,
 		if (!rc) {
 			rc = copy_to_user((u64 __user *) args, &irq_offset,
 					sizeof(irq_offset));
-			if (rc)
+			if (rc) {
 				ocxl_afu_irq_free(ctx, irq_offset);
+				return -EFAULT;
+			}
 		}
 		break;
 
@@ -329,7 +331,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count,
 
 	used += sizeof(header);
 
-	rc = (ssize_t) used;
+	rc = used;
 	return rc;
 }
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread