* [PATCH] selftests/powerpc: Fix missing clean of pmu/lib.o
@ 2018-02-28 9:32 Michael Ellerman
2018-03-05 12:36 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2018-02-28 9:32 UTC (permalink / raw)
To: linuxppc-dev
The tm-resched-dscr test links against pmu/lib.o, but we don't have a
rule to clean pmu/lib.o. This can lead to a build break if you build
for big endian and then little, or vice versa.
Fix it by making tm-resched-dscr depend on pmu/lib.c, causing the code
to be built directly in, meaning no .o is generated.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
tools/testing/selftests/powerpc/tm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/Makefile b/tools/testing/selftests/powerpc/tm/Makefile
index a23453943ad2..5c72ff978f27 100644
--- a/tools/testing/selftests/powerpc/tm/Makefile
+++ b/tools/testing/selftests/powerpc/tm/Makefile
@@ -16,7 +16,7 @@ $(OUTPUT)/tm-syscall: tm-syscall-asm.S
$(OUTPUT)/tm-syscall: CFLAGS += -I../../../../../usr/include
$(OUTPUT)/tm-tmspr: CFLAGS += -pthread
$(OUTPUT)/tm-vmx-unavail: CFLAGS += -pthread -m64
-$(OUTPUT)/tm-resched-dscr: ../pmu/lib.o
+$(OUTPUT)/tm-resched-dscr: ../pmu/lib.c
$(OUTPUT)/tm-unavailable: CFLAGS += -O0 -pthread -m64 -Wno-error=uninitialized -mvsx
$(OUTPUT)/tm-trap: CFLAGS += -O0 -pthread -m64
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: selftests/powerpc: Fix missing clean of pmu/lib.o
2018-02-28 9:32 [PATCH] selftests/powerpc: Fix missing clean of pmu/lib.o Michael Ellerman
@ 2018-03-05 12:36 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-03-05 12:36 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
On Wed, 2018-02-28 at 09:32:57 UTC, Michael Ellerman wrote:
> The tm-resched-dscr test links against pmu/lib.o, but we don't have a
> rule to clean pmu/lib.o. This can lead to a build break if you build
> for big endian and then little, or vice versa.
>
> Fix it by making tm-resched-dscr depend on pmu/lib.c, causing the code
> to be built directly in, meaning no .o is generated.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/b7abbd5a3533a31a1e7d4696ea275d
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 9:32 [PATCH] selftests/powerpc: Fix missing clean of pmu/lib.o Michael Ellerman
2018-03-05 12:36 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).