* [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot
@ 2010-11-23 15:10 Sergej.Stepanov
2010-11-23 16:50 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Sergej.Stepanov @ 2010-11-23 15:10 UTC (permalink / raw)
To: linuxppc-dev
This patch should fix the following problem:
1. the jffs2-image update in the u-boot was ok=20
2. first restart and first mount of the NAND-flash-partition was also ok
3. before the restart of controller there are no any activity on NAND-flas=
h except of the jffs2_gcd_mtdX-process ...
4. BUT after the second restart the NAND-flash-partition could not be real=
ly used after the second mount,
dmesg filled with messages:
...
jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x03ce0000: 0xc0=
ff instead
jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x03d00000: 0xc0=
ff instead
....
Just for for info: the behaviour observed on mpc8313-based board.
The only activity on NAND-flash was the garbage collector process, that loo=
ks for CLEANMARKER-nodes
Signed-off-by: Sergej Stepanov <Sergej.Stepanov@ids.de>
Cc: Rolf Riehle <Rolf.Riehle@ids.de>
--
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_n=
and.c
index c141b07..775c2f5 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -388,6 +388,7 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsi=
gned int command,
"page_addr: 0x%x, column: 0x%x.\n",
page_addr, column);
=20
+ elbc_fcm_ctrl->column =3D column;
elbc_fcm_ctrl->use_mdr =3D 1;
=20
fcr =3D (NAND_CMD_STATUS << FCR_CMD1_SHIFT) |
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot
2010-11-23 15:10 [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot Sergej.Stepanov
@ 2010-11-23 16:50 ` Scott Wood
[not found] ` <4206182445660643B9AEB8D4E55BBD0A106A0BB1F3@HERMES2>
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2010-11-23 16:50 UTC (permalink / raw)
To: Sergej.Stepanov; +Cc: linuxppc-dev
On Tue, 23 Nov 2010 16:10:54 +0100
<Sergej.Stepanov@ids.de> wrote:
> This patch should fix the following problem:
> 1. the jffs2-image update in the u-boot was ok
> 2. first restart and first mount of the NAND-flash-partition was also ok
> 3. before the restart of controller there are no any activity on NAND-flash except of the jffs2_gcd_mtdX-process ...
> 4. BUT after the second restart the NAND-flash-partition could not be really used after the second mount,
> dmesg filled with messages:
> ...
> jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x03ce0000: 0xc0ff instead
> jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x03d00000: 0xc0ff instead
> ....
> Just for for info: the behaviour observed on mpc8313-based board.
> The only activity on NAND-flash was the garbage collector process, that looks for CLEANMARKER-nodes
>
> Signed-off-by: Sergej Stepanov <Sergej.Stepanov@ids.de>
> Cc: Rolf Riehle <Rolf.Riehle@ids.de>
> --
Acked-by: Scott Wood <scottwood@freescale.com>
>
> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
> index c141b07..775c2f5 100644
> --- a/drivers/mtd/nand/fsl_elbc_nand.c
> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
> @@ -388,6 +388,7 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
> "page_addr: 0x%x, column: 0x%x.\n",
> page_addr, column);
>
> + elbc_fcm_ctrl->column = column;
> elbc_fcm_ctrl->use_mdr = 1;
This was broken by commit 3ab8f2a2e7011c5e83363b42950757e46ef06824
That commit also removed the setting of ctrl->oob to 0, which should
also be restored.
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* Resend: Re: [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot
[not found] ` <20101123111853.23481aa7@udp111988uds.am.freescale.net>
@ 2010-11-23 17:29 ` Sergej.Stepanov
0 siblings, 0 replies; 3+ messages in thread
From: Sergej.Stepanov @ 2010-11-23 17:29 UTC (permalink / raw)
To: scottwood; +Cc: linuxppc-dev
U29ycnkgU2NvdHQsIGkgcmVzZW5kIHRoZSBlbWFpbCBhbHNvIHRvIGxpbnV4cHBjLWRldgoKQW0g
RGllbnN0YWcsIGRlbiAyMy4xMS4yMDEwLCAxMToxOCAtMDYwMCBzY2hyaWViIFNjb3R0IFdvb2Q6
Cgo+IAo+IEl0IG9ubHkgbWFrZXMgYSBkaWZmZXJlbmNlIG9uIHNtYWxsLXBhZ2UgTkFORC4KT3Vy
IGJvYXJkIGhhcyBhIGxhcmdlIHBhZ2UgTkFORAoKPiAKPiA+IEknbGwgcmVzZW5kIHRoZSBwYXRj
aC4KPiAKPiBQbGVhc2UgaW5jbHVkZSBsaW51eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9yZyBhbmQg
RGF2aWQgV29vZGhvdXNlCj4gPGR3bXcyQGluZnJhZGVhZC5vcmc+IC0tIHRoYXQncyB3aG8gd291
bGQgYmUgYXBwbHlpbmcgaXQuCm9rCgpTZXJnZWouCg==
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-23 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-23 15:10 [PATCH] Fixing the garbage collector problem after NAND-flash image record in u-boot Sergej.Stepanov
2010-11-23 16:50 ` Scott Wood
[not found] ` <4206182445660643B9AEB8D4E55BBD0A106A0BB1F3@HERMES2>
[not found] ` <20101123111853.23481aa7@udp111988uds.am.freescale.net>
2010-11-23 17:29 ` Resend: " Sergej.Stepanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).