linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/44x/bamboo: Fix PCI range
@ 2018-12-11  2:27 Benjamin Herrenschmidt
  2018-12-22  9:54 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2018-12-11  2:27 UTC (permalink / raw)
  To: linuxppc-dev

From 88509506b80b4960004146280eb740be64513a0b Mon Sep 17 00:00:00 2001
The bamboo dts has a bug: it uses a non-naturally aligned range
for PCI memory space. This isnt' supported by the code, thus
causing PCI to break on this system.

This is due to the fact that while the chip memory map has 1G
reserved for PCI memory, it's only 512M aligned. The code doesn't
know how to split that into 2 different PMMs and fails, so limit
the region to 512M.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 arch/powerpc/boot/dts/bamboo.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/boot/dts/bamboo.dts b/arch/powerpc/boot/dts/bamboo.dts
index 538e42b..b5861fa 100644
--- a/arch/powerpc/boot/dts/bamboo.dts
+++ b/arch/powerpc/boot/dts/bamboo.dts
@@ -268,8 +268,10 @@
 			/* Outbound ranges, one memory and one IO,
 			 * later cannot be changed. Chip supports a second
 			 * IO range but we don't use it for now
+			 * The chip also supports a larger memory range but
+			 * it's not naturally aligned, so our code will break
 			 */
-			ranges = <0x02000000 0x00000000 0xa0000000 0x00000000 0xa0000000 0x00000000 0x40000000
+			ranges = <0x02000000 0x00000000 0xa0000000 0x00000000 0xa0000000 0x00000000 0x20000000
 				  0x02000000 0x00000000 0x00000000 0x00000000 0xe0000000 0x00000000 0x00100000
 				  0x01000000 0x00000000 0x00000000 0x00000000 0xe8000000 0x00000000 0x00010000>;
 



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: powerpc/44x/bamboo: Fix PCI range
  2018-12-11  2:27 [PATCH] powerpc/44x/bamboo: Fix PCI range Benjamin Herrenschmidt
@ 2018-12-22  9:54 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-12-22  9:54 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, linuxppc-dev

On Tue, 2018-12-11 at 02:27:33 UTC, Benjamin Herrenschmidt wrote:
> >From 88509506b80b4960004146280eb740be64513a0b Mon Sep 17 00:00:00 2001
> The bamboo dts has a bug: it uses a non-naturally aligned range
> for PCI memory space. This isnt' supported by the code, thus
> causing PCI to break on this system.
> 
> This is due to the fact that while the chip memory map has 1G
> reserved for PCI memory, it's only 512M aligned. The code doesn't
> know how to split that into 2 different PMMs and fails, so limit
> the region to 512M.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3cfb9ebe906b51f2942b1e251009bb

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-22 10:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11  2:27 [PATCH] powerpc/44x/bamboo: Fix PCI range Benjamin Herrenschmidt
2018-12-22  9:54 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).