* Add "mpc5200-simple-platform" to the list of supported boards
@ 2009-06-05 23:20 Marcelo Dalmas
2009-06-05 23:52 ` Grant Likely
2009-06-06 0:28 ` Benjamin Herrenschmidt
0 siblings, 2 replies; 4+ messages in thread
From: Marcelo Dalmas @ 2009-06-05 23:20 UTC (permalink / raw)
To: linuxppc-dev
Hello,=0A=0AAdding "mpc5200-simple-platform" to the list of supported boar=
ds allow to use the option "Generic support for simple MPC5200 based boards=
" without patching the kernel. Just set model to "mpc5200-simple-plataform"=
on your dts file.=0A=0A=0Adiff --git a/arch/powerpc/platforms/52xx/mpc5200=
_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c=0Aindex c31e5b5..a=
2df795 100644=0A--- a/arch/powerpc/platforms/52xx/mpc5200_simple.c=0A+++ b/=
arch/powerpc/platforms/52xx/mpc5200_simple.c=0A@@ -50,6 +50,7 @@ static voi=
d __init mpc5200_simple_setup_arch(void)=0A =0A /* list of the supported bo=
ards */=0A static char *board[] __initdata =3D {=0A+=09"mpc5200-simple-plat=
form",=0A =09"intercontrol,digsy-mtc",=0A =09"phytec,pcm030",=0A =09"phytec=
,pcm032",=0A=0A=0A=0A=0A Veja quais s=E3o os assuntos do momento no Ya=
hoo! +Buscados=0Ahttp://br.maisbuscados.yahoo.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Add "mpc5200-simple-platform" to the list of supported boards
2009-06-05 23:20 Add "mpc5200-simple-platform" to the list of supported boards Marcelo Dalmas
@ 2009-06-05 23:52 ` Grant Likely
2009-06-06 0:28 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 4+ messages in thread
From: Grant Likely @ 2009-06-05 23:52 UTC (permalink / raw)
To: Marcelo Dalmas; +Cc: linuxppc-dev
On Fri, Jun 5, 2009 at 5:20 PM, Marcelo Dalmas<m_dalmas@yahoo.com.br> wrote=
:
>
> Hello,
>
> Adding =A0"mpc5200-simple-platform" to the list of supported boards allow=
to use the option "Generic support for simple MPC5200 based boards" withou=
t patching the kernel. Just set model to "mpc5200-simple-plataform" on your=
dts file.
>
>
> diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/=
platforms/52xx/mpc5200_simple.c
> index c31e5b5..a2df795 100644
> --- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> @@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
>
> =A0/* list of the supported boards */
> =A0static char *board[] __initdata =3D {
> + =A0 =A0 =A0 "mpc5200-simple-platform",
> =A0 =A0 =A0 =A0"intercontrol,digsy-mtc",
> =A0 =A0 =A0 =A0"phytec,pcm030",
> =A0 =A0 =A0 =A0"phytec,pcm032",
Sorry, nack. For the time being, board support is listed explicitly
in mpc5200_simple.c and 'generic' compatible values are strongly
discouraged. This is on purpose.
I have been thinking about coming up with a method for generic mpc5200
platform support code to bind against an otherwise unknown mpc5200
board, but there are subtleties here and considerable pain if it is
done wrong.
In the mean time, just patch your kernel with your board name(s) and
don't try to use a generic value like mpc5200-simple-platform.
BTW, please cc: the appropriate maintainers and developers when
posting patches to the Linux kernel. The MAINTAINERS file and
'scripts/get_maintainer.pl -f <filename>' are useful tools here.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Add "mpc5200-simple-platform" to the list of supported boards
2009-06-05 23:20 Add "mpc5200-simple-platform" to the list of supported boards Marcelo Dalmas
2009-06-05 23:52 ` Grant Likely
@ 2009-06-06 0:28 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2009-06-06 0:28 UTC (permalink / raw)
To: Marcelo Dalmas; +Cc: linuxppc-dev
On Fri, 2009-06-05 at 16:20 -0700, Marcelo Dalmas wrote:
> Hello,
>
> Adding "mpc5200-simple-platform" to the list of supported boards allow to use the option "Generic support for simple MPC5200 based boards" without patching the kernel. Just set model to "mpc5200-simple-plataform" on your dts file.
I'm generally against that. Some time you'll need to diverge and poof !
you lost the ability to identify your board... it's also a very linux
centric thing to put in the device-tree.
Cheers,
Ben.
> diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> index c31e5b5..a2df795 100644
> --- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> @@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
>
> /* list of the supported boards */
> static char *board[] __initdata = {
> + "mpc5200-simple-platform",
> "intercontrol,digsy-mtc",
> "phytec,pcm030",
> "phytec,pcm032",
>
>
>
>
> Veja quais são os assuntos do momento no Yahoo! +Buscados
> http://br.maisbuscados.yahoo.com
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Add "mpc5200-simple-platform" to the list of supported boards
@ 2009-06-05 21:01 Marcelo Dalmas
0 siblings, 0 replies; 4+ messages in thread
From: Marcelo Dalmas @ 2009-06-05 21:01 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
Hello,
Adding "mpc5200-simple-platform" to the list of supported boards allow to use the option "Generic support for simple MPC5200 based boards" without patching the kernel. Just set model to "mpc5200-simple-plataform" on your dts file.
Veja quais são os assuntos do momento no Yahoo! +Buscados
http://br.maisbuscados.yahoo.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: add_mpc5200_simple_platform_to_supported_boards.patch --]
[-- Type: text/x-diff; name="add_mpc5200_simple_platform_to_supported_boards.patch", Size: 476 bytes --]
diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/platforms/52xx/mpc5200_simple.c
index c31e5b5..a2df795 100644
--- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
+++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
@@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
/* list of the supported boards */
static char *board[] __initdata = {
+ "mpc5200-simple-platform",
"intercontrol,digsy-mtc",
"phytec,pcm030",
"phytec,pcm032",
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-06 0:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-05 23:20 Add "mpc5200-simple-platform" to the list of supported boards Marcelo Dalmas
2009-06-05 23:52 ` Grant Likely
2009-06-06 0:28 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-06-05 21:01 Marcelo Dalmas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).