linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst
@ 2018-11-02 21:17 Rasmus Villemoes
  2019-11-14  9:08 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2018-11-02 21:17 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Rasmus Villemoes, linux-kernel

This variable has no reason to have external linkage, and since it is
only used in an __init function, it might as well be made __initconst
also.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 drivers/macintosh/ans-lcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index c8e078b911c7..a7a79a935f6a 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -147,7 +147,8 @@ static struct miscdevice anslcd_dev = {
 	&anslcd_fops
 };
 
-const char anslcd_logo[] =	"********************"  /* Line #1 */
+static const char anslcd_logo[] __initconst =
+				"********************"  /* Line #1 */
 				"*      LINUX!      *"  /* Line #3 */
 				"*    Welcome to    *"  /* Line #2 */
 				"********************"; /* Line #4 */
-- 
2.19.1.6.gbde171bbf5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst
  2018-11-02 21:17 [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst Rasmus Villemoes
@ 2019-11-14  9:08 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2019-11-14  9:08 UTC (permalink / raw)
  To: Rasmus Villemoes, Benjamin Herrenschmidt
  Cc: Rasmus Villemoes, linuxppc-dev, linux-kernel

On Fri, 2018-11-02 at 21:17:06 UTC, Rasmus Villemoes wrote:
> This variable has no reason to have external linkage, and since it is
> only used in an __init function, it might as well be made __initconst
> also.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3775026a654c15c92c8ac2d53f3fd14fdd1980df

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-14 10:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 21:17 [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst Rasmus Villemoes
2019-11-14  9:08 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).