* powerpc/xmon: don't access ASDR in VMs
@ 2020-01-07 2:16 Sukadev Bhattiprolu
2020-01-07 2:59 ` Andrew Donnellan
2020-01-29 5:17 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2020-01-07 2:16 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Date: Mon, 6 Jan 2020 13:50:02 -0600
Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs
ASDR is HV-privileged and must only be accessed in HV-mode.
Fixes a Program Check (0x700) when xmon in a VM dumps SPRs.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
---
arch/powerpc/xmon/xmon.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 02fae453c2ec..b8d179b5cf4f 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1949,15 +1949,14 @@ static void dump_300_sprs(void)
printf("pidr = %.16lx tidr = %.16lx\n",
mfspr(SPRN_PID), mfspr(SPRN_TIDR));
- printf("asdr = %.16lx psscr = %.16lx\n",
- mfspr(SPRN_ASDR), hv ? mfspr(SPRN_PSSCR)
- : mfspr(SPRN_PSSCR_PR));
+ printf("psscr = %.16lx\n",
+ hv ? mfspr(SPRN_PSSCR) : mfspr(SPRN_PSSCR_PR));
if (!hv)
return;
- printf("ptcr = %.16lx\n",
- mfspr(SPRN_PTCR));
+ printf("ptcr = %.16lx asdr = %.16lx\n",
+ mfspr(SPRN_PTCR), mfspr(SPRN_ASDR));
#endif
}
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: powerpc/xmon: don't access ASDR in VMs
2020-01-07 2:16 powerpc/xmon: don't access ASDR in VMs Sukadev Bhattiprolu
@ 2020-01-07 2:59 ` Andrew Donnellan
2020-01-29 5:17 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2020-01-07 2:59 UTC (permalink / raw)
To: Sukadev Bhattiprolu, Michael Ellerman; +Cc: linuxppc-dev
On 7/1/20 1:16 pm, Sukadev Bhattiprolu wrote:
> From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
> Date: Mon, 6 Jan 2020 13:50:02 -0600
> Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs
>
> ASDR is HV-privileged and must only be accessed in HV-mode.
> Fixes a Program Check (0x700) when xmon in a VM dumps SPRs.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
I think this should be:
Fixes: d1e1b351f50f9 ("powerpc/xmon: Add ISA v3.0 SPRs to SPR dump")
Cc: stable@vger.kernel.org
Apart from that
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/xmon: don't access ASDR in VMs
2020-01-07 2:16 powerpc/xmon: don't access ASDR in VMs Sukadev Bhattiprolu
2020-01-07 2:59 ` Andrew Donnellan
@ 2020-01-29 5:17 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-01-29 5:17 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: linuxppc-dev
On Tue, 2020-01-07 at 02:16:33 UTC, Sukadev Bhattiprolu wrote:
> >From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
> Date: Mon, 6 Jan 2020 13:50:02 -0600
> Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs
>
> ASDR is HV-privileged and must only be accessed in HV-mode.
> Fixes a Program Check (0x700) when xmon in a VM dumps SPRs.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c2a20711fc181e7f22ee5c16c28cb9578af84729
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-29 6:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 2:16 powerpc/xmon: don't access ASDR in VMs Sukadev Bhattiprolu
2020-01-07 2:59 ` Andrew Donnellan
2020-01-29 5:17 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).