* [PATCH v2 2/7] dt/powerpc: Use of_get_child_by_name to get a named child.
@ 2012-09-14 8:18 Srinivas KANDAGATLA
2012-09-14 13:06 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-09-14 8:18 UTC (permalink / raw)
To: benh, bergner
Cc: robherring2, devicetree-discuss, linuxppc-dev, srinivas.kandagatla
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
As follow-up to "dt: introduce of_get_child_by_name to get child node by
name." patch, This patch removes some of the code duplication in the
driver by replacing it with of_get_child_by_name instead.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/powerpc/kernel/prom.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index f191bf0..80e5b6c 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -735,7 +735,6 @@ void __init early_init_devtree(void *params)
*/
struct device_node *of_find_next_cache_node(struct device_node *np)
{
- struct device_node *child;
const phandle *handle;
handle = of_get_property(np, "l2-cache", NULL);
@@ -749,9 +748,7 @@ struct device_node *of_find_next_cache_node(struct device_node *np)
* beneath CPU nodes.
*/
if (!strcmp(np->type, "cpu"))
- for_each_child_of_node(np, child)
- if (!strcmp(child->type, "cache"))
- return child;
+ return of_get_child_by_name(np, "cache");
return NULL;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/7] dt/powerpc: Use of_get_child_by_name to get a named child.
2012-09-14 8:18 [PATCH v2 2/7] dt/powerpc: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
@ 2012-09-14 13:06 ` Rob Herring
2012-09-14 13:15 ` Srinivas KANDAGATLA
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2012-09-14 13:06 UTC (permalink / raw)
To: Srinivas KANDAGATLA; +Cc: bergner, devicetree-discuss, linuxppc-dev
On 09/14/2012 03:18 AM, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> As follow-up to "dt: introduce of_get_child_by_name to get child node by
> name." patch, This patch removes some of the code duplication in the
> driver by replacing it with of_get_child_by_name instead.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> arch/powerpc/kernel/prom.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> index f191bf0..80e5b6c 100644
> --- a/arch/powerpc/kernel/prom.c
> +++ b/arch/powerpc/kernel/prom.c
> @@ -735,7 +735,6 @@ void __init early_init_devtree(void *params)
> */
> struct device_node *of_find_next_cache_node(struct device_node *np)
> {
> - struct device_node *child;
> const phandle *handle;
>
> handle = of_get_property(np, "l2-cache", NULL);
> @@ -749,9 +748,7 @@ struct device_node *of_find_next_cache_node(struct device_node *np)
> * beneath CPU nodes.
> */
> if (!strcmp(np->type, "cpu"))
> - for_each_child_of_node(np, child)
> - if (!strcmp(child->type, "cache"))
name and type are not the same thing.
Rob
> - return child;
> + return of_get_child_by_name(np, "cache");
>
> return NULL;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/7] dt/powerpc: Use of_get_child_by_name to get a named child.
2012-09-14 13:06 ` Rob Herring
@ 2012-09-14 13:15 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-09-14 13:15 UTC (permalink / raw)
To: Rob Herring; +Cc: bergner, devicetree-discuss, linuxppc-dev
My bad...
Will skip this patch in next patch-set...
On 14/09/12 14:06, Rob Herring wrote:
> On 09/14/2012 03:18 AM, Srinivas KANDAGATLA wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>>
>> As follow-up to "dt: introduce of_get_child_by_name to get child node by
>> name." patch, This patch removes some of the code duplication in the
>> driver by replacing it with of_get_child_by_name instead.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> ---
>> arch/powerpc/kernel/prom.c | 5 +----
>> 1 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
>> index f191bf0..80e5b6c 100644
>> --- a/arch/powerpc/kernel/prom.c
>> +++ b/arch/powerpc/kernel/prom.c
>> @@ -735,7 +735,6 @@ void __init early_init_devtree(void *params)
>> */
>> struct device_node *of_find_next_cache_node(struct device_node *np)
>> {
>> - struct device_node *child;
>> const phandle *handle;
>>
>> handle = of_get_property(np, "l2-cache", NULL);
>> @@ -749,9 +748,7 @@ struct device_node *of_find_next_cache_node(struct device_node *np)
>> * beneath CPU nodes.
>> */
>> if (!strcmp(np->type, "cpu"))
>> - for_each_child_of_node(np, child)
>> - if (!strcmp(child->type, "cache"))
> name and type are not the same thing.
>
> Rob
>
>> - return child;
>> + return of_get_child_by_name(np, "cache");
>>
>> return NULL;
>> }
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-14 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-14 8:18 [PATCH v2 2/7] dt/powerpc: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
2012-09-14 13:06 ` Rob Herring
2012-09-14 13:15 ` Srinivas KANDAGATLA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).