From: Timur Tabi <timur@freescale.com>
To: Jia Hongtao <B38951@freescale.com>
Cc: B07421@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [linuxppc-release] [PATCH] powerpc/fsl-pci: Add PCI controller ATMU PM support
Date: Thu, 1 Nov 2012 08:25:54 -0500 [thread overview]
Message-ID: <50927862.9080909@freescale.com> (raw)
In-Reply-To: <1351736348-26754-1-git-send-email-B38951@freescale.com>
Jia Hongtao wrote:
> +#ifdef CONFIG_SUSPEND
> +static int fsl_pci_resume(struct platform_device *pdev)
> +{
> + struct pci_controller *hose;
> + struct resource pci_rsrc;
> +
> + hose = pci_find_hose_for_OF_device(pdev->dev.of_node);
> + of_address_to_resource(pdev->dev.of_node, 0, &pci_rsrc);
> + setup_pci_atmu(hose, &pci_rsrc);
> +
> + return 0;
> +}
Some of these functions can fail, so they should return an error code if
they do.
> +#endif
> +
> static struct platform_driver fsl_pci_driver = {
> .driver = {
> .name = "fsl-pci",
> .of_match_table = pci_ids,
> },
> .probe = fsl_pci_probe,
> +#ifdef CONFIG_SUSPEND
> + .resume = fsl_pci_resume,
> +#endif
Do this instead:
#ifdef CONFIG_SUSPEND
static int fsl_pci_resume(struct platform_device *pdev)
...
#else
#define fsl_pci_resume NULL
#endif
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-11-01 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 2:19 [PATCH] powerpc/fsl-pci: Add PCI controller ATMU PM support Jia Hongtao
2012-11-01 13:25 ` Timur Tabi [this message]
2012-11-05 2:40 ` [linuxppc-release] " Jia Hongtao-B38951
2012-11-05 19:18 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50927862.9080909@freescale.com \
--to=timur@freescale.com \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).