From: Timur Tabi <b04825@freescale.com>
To: Jia Hongtao-B38951 <B38951@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Li Yang-R58472 <r58472@freescale.com>
Subject: Re: [linuxppc-release] [PATCH] powerpc/fsl-pci: Add PCI controller ATMU PM support
Date: Mon, 5 Nov 2012 13:18:38 -0600 [thread overview]
Message-ID: <5098110E.20201@freescale.com> (raw)
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01B2F820@039-SN1MPN1-004.039d.mgd.msft.net>
Jia Hongtao-B38951 wrote:
>>
>>> +#ifdef CONFIG_SUSPEND
>>> +static int fsl_pci_resume(struct platform_device *pdev)
>>> +{
>>> + struct pci_controller *hose;
>>> + struct resource pci_rsrc;
>>> +
>>> + hose = pci_find_hose_for_OF_device(pdev->dev.of_node);
>>> + of_address_to_resource(pdev->dev.of_node, 0, &pci_rsrc);
>>> + setup_pci_atmu(hose, &pci_rsrc);
>>> +
>>> + return 0;
>>> +}
>>
>> Some of these functions can fail, so they should return an error code if
>> they do.
>
> I checked the of_address_to_resource function now.
> Is that necessary to check other two fuctions?
Yes, check to ensure that 'hose' is not NULL.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2012-11-05 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 2:19 [PATCH] powerpc/fsl-pci: Add PCI controller ATMU PM support Jia Hongtao
2012-11-01 13:25 ` [linuxppc-release] " Timur Tabi
2012-11-05 2:40 ` Jia Hongtao-B38951
2012-11-05 19:18 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098110E.20201@freescale.com \
--to=b04825@freescale.com \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).