linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [BUG?]  possible bug in user_enable_block_step()
@ 2013-04-11 22:38 Chris Friesen
  0 siblings, 0 replies; only message in thread
From: Chris Friesen @ 2013-04-11 22:38 UTC (permalink / raw)
  To: linuxppc-dev


Hi,

I'm looking at user_enable_block_step() in current kernels and it has 
the following:

#ifdef CONFIG_PPC_ADV_DEBUG_REGS
		task->thread.dbcr0 &= ~DBCR0_IC;
		task->thread.dbcr0 = DBCR0_IDM | DBCR0_BT;
		regs->msr |= MSR_DE;


Should it be as follows?

		task->thread.dbcr0 |= DBCR0_IDM | DBCR0_BT;


If not, then what's the point of clearing the DBCR0_IC bit in the 
previous line?

Chris


-- 

Chris Friesen
Software Designer

500 Palladium Drive, Suite 2100
Ottawa, Ontario K2N 1C2, Canada
www.genband.com
office:+1.343.883.2717
chris.friesen@genband.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-11 22:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-11 22:38 [BUG?] possible bug in user_enable_block_step() Chris Friesen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).