From: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jonas Bonn <jonas@southpole.se>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>,
"microblaze-uclinux@itee.uq.edu.au"
<microblaze-uclinux@itee.uq.edu.au>,
"linux@openrisc.net" <linux@openrisc.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 3/4] powerpc: refactor of_get_cpu_node to support other architectures
Date: Fri, 16 Aug 2013 13:44:56 +0100 [thread overview]
Message-ID: <520E1EC8.1010001@arm.com> (raw)
In-Reply-To: <1376656351.25016.2.camel@pasglop>
On 16/08/13 13:32, Benjamin Herrenschmidt wrote:
> On Fri, 2013-08-16 at 09:48 +0100, Sudeep KarkadaNagesha wrote:
>=20
>>> Naming is a bit gross. You might want to make it clearer that
>>> we are talking about CPU IDs in the device-tree here.
>>>
>> Any particular preference to the name or just a note is sufficient.
>> Also unlike PPC, in ARM we don't set hard processor id value based
>> values read from device tree. DT must contain the values matching to the
>> hardware ID registers.
>=20
> This is exactly the same on ppc. We don't "set" HW values. The
> device-tree content matches the HW internals. Some processors have a
> "PIR" register as well which contains the HW value, in this case the
> device-tree must contain the same value as the PIR on that processor.
>=20
Ok, I misread the function 'set_hard_smp_processor_id' function.
BTW, you didn't mention if you are OK by just have this clearly
documented in the function and/or you have any preference/better name.
I will send the next version based on that. I have even compile tested
:) now on PPC.
Regards,
Sudeep
next prev parent reply other threads:[~2013-08-16 12:44 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com>
2013-08-15 17:09 ` [RFC PATCH 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 1/4] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 2/4] openrisc: " Sudeep KarkadaNagesha
2013-08-16 9:41 ` Sudeep KarkadaNagesha
2013-08-21 5:10 ` Jonas Bonn
2013-08-15 17:09 ` [RFC PATCH 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 4:49 ` Benjamin Herrenschmidt
2013-08-16 8:48 ` Sudeep KarkadaNagesha
2013-08-16 12:32 ` Benjamin Herrenschmidt
2013-08-16 12:44 ` Sudeep KarkadaNagesha [this message]
2013-08-16 4:50 ` Benjamin Herrenschmidt
2013-08-16 8:43 ` Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 22:13 ` Benjamin Herrenschmidt
2013-08-19 10:13 ` Sudeep KarkadaNagesha
2013-08-17 10:50 ` Tomasz Figa
2013-08-17 22:09 ` Benjamin Herrenschmidt
2013-08-17 22:22 ` Tomasz Figa
2013-08-19 10:19 ` Mark Rutland
2013-08-19 13:02 ` Rob Herring
2013-08-19 13:56 ` Sudeep KarkadaNagesha
2013-08-22 13:59 ` Mark Rutland
2013-08-22 16:51 ` Sudeep KarkadaNagesha
2013-08-28 19:46 ` Grant Likely
2013-08-29 9:50 ` Lorenzo Pieralisi
2013-08-16 17:39 ` [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 22:14 ` Benjamin Herrenschmidt
2013-08-19 10:21 ` Sudeep KarkadaNagesha
2013-08-19 13:11 ` Rob Herring
2013-08-19 13:24 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 00/19] DT/core: update cpu device of_node Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 01/19] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 02/19] openrisc: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 03/19] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-20 12:27 ` Rafael J. Wysocki
2013-08-20 12:22 ` Sudeep KarkadaNagesha
2013-08-20 21:48 ` Benjamin Herrenschmidt
2013-08-22 6:15 ` Benjamin Herrenschmidt
2013-08-22 13:29 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 04/19] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 05/19] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture Sudeep KarkadaNagesha
2013-08-20 12:28 ` Rafael J. Wysocki
2013-08-20 15:18 ` Greg Kroah-Hartman
2013-08-20 9:30 ` [PATCH v4 07/19] of/device: add helper to get cpu device node from logical cpu index Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 08/19] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 09/19] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 10/19] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 11/19] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 12/19] cpufreq: cpufreq-cpu0: " Sudeep KarkadaNagesha
2013-09-06 13:44 ` Guennadi Liakhovetski
2013-09-09 9:24 ` Sudeep KarkadaNagesha
2013-09-09 14:32 ` Shawn Guo
2013-09-09 15:24 ` Sudeep KarkadaNagesha
2013-09-10 2:44 ` Shawn Guo
2013-09-10 10:56 ` Sudeep KarkadaNagesha
2013-09-10 11:19 ` Shawn Guo
2013-08-20 9:30 ` [PATCH v4 13/19] cpufreq: highbank-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 14/19] cpufreq: spear-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 15/19] cpufreq: kirkwood-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 16/19] cpufreq: arm_big_little: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 17/19] cpufreq: maple-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 18/19] cpufreq: pmac64-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 19/19] cpufreq: pmac32-cpufreq: " Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E1EC8.1010001@arm.com \
--to=sudeep.karkadanagesha@arm.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jonas@southpole.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@openrisc.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).