linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: hongbo.zhang@freescale.com
Cc: devicetree@vger.kernel.org, vinod.koul@intel.com,
	linux-kernel@vger.kernel.org, djbw@fb.com,
	scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 1/3] DMA: Freescale: revise device tree binding document
Date: Wed, 21 Aug 2013 16:33:18 -0600	[thread overview]
Message-ID: <5215402E.70007@wwwdotorg.org> (raw)
In-Reply-To: <1375094944-3343-2-git-send-email-hongbo.zhang@freescale.com>

On 07/29/2013 04:49 AM, hongbo.zhang@freescale.com wrote:
> From: Hongbo Zhang <hongbo.zhang@freescale.com>
> 
> This patch updates the discription of each type of DMA controller and its
> channels, it is preparation for adding another new DMA controller binding, it
> also fixes some defects of indent for text alignment at the same time.

> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt

> -- compatible        : compatible list, contains 2 entries, first is
> -		 "fsl,CHIP-dma", where CHIP is the processor
> -		 (mpc8349, mpc8360, etc.) and the second is
> -		 "fsl,elo-dma"
> +- compatible        : must include "fsl,elo-dma"

Why remove the list of supported compatible values. Lately it seems that
we're moving towards listing more/all the values rather than removing
their documentation...

> -- ranges		: Should be defined as specified in 1) to describe the
> -		  DMA controller channels.
> +- ranges            : describes the mapping between the address space of the
> +                      DMA channels and the address space of the DMA controller

What is "the address space of the DMA controller". Perhaps this should
say "the CPU-visible address space" instead?

  parent reply	other threads:[~2013-08-21 22:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 10:49 [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine hongbo.zhang
2013-07-29 10:49 ` [PATCH v7 1/3] DMA: Freescale: revise device tree binding document hongbo.zhang
2013-07-29 22:09   ` Scott Wood
2013-08-21 22:33   ` Stephen Warren [this message]
2013-08-21 22:45     ` Scott Wood
2013-08-21 23:12       ` Stephen Warren
2013-08-21 23:33         ` Scott Wood
2013-07-29 10:49 ` [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes hongbo.zhang
2013-07-29 22:10   ` Scott Wood
2013-07-30  2:10     ` Hongbo Zhang
2013-08-21 22:40   ` Stephen Warren
2013-08-21 22:57     ` Scott Wood
2013-08-21 23:15       ` Stephen Warren
2013-08-21 23:31         ` Scott Wood
2013-08-22  0:27           ` Timur Tabi
2013-08-21 23:00     ` Scott Wood
2013-08-21 23:16       ` Stephen Warren
2013-08-23  3:17         ` Hongbo Zhang
2013-08-26 10:33           ` Hongbo Zhang
2013-07-29 10:49 ` [PATCH v7 3/3] DMA: Freescale: update driver to support 8-channel DMA engine hongbo.zhang
2013-07-29 10:59 ` [PATCH v7 0/3] DMA: Freescale: Add support for " Vinod Koul
2013-07-30  2:08   ` Hongbo Zhang
2013-08-20  8:33   ` Hongbo Zhang
2013-08-20  8:15     ` Vinod Koul
2013-08-21  6:59       ` Hongbo Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5215402E.70007@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djbw@fb.com \
    --cc=hongbo.zhang@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).