linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Scott Wood <scottwood@freescale.com>
Cc: devicetree@vger.kernel.org,
	Stephen Warren <swarren@wwwdotorg.org>,
	hongbo.zhang@freescale.com, lkml <linux-kernel@vger.kernel.org>,
	"vinod.koul@intel.com" <vinod.koul@intel.com>,
	djbw@fb.com,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes
Date: Wed, 21 Aug 2013 19:27:52 -0500	[thread overview]
Message-ID: <CAOZdJXXvyFQZqyKjDerESB7RmZ9J76R40xLtNGfTd1Wv=W-bow@mail.gmail.com> (raw)
In-Reply-To: <1377127873.5029.72.camel@snotra.buserror.net>

On Wed, Aug 21, 2013 at 6:31 PM, Scott Wood <scottwood@freescale.com> wrote:
>
>> > Other than "this is how the existing binding works and we're not going
>> > to break compatibility", it allows the OS more flexibility to choose
>> > whether to bind to controllers or directly to the channels.  Sometimes a
>> > channel will be labelled with a different compatible if it has a fixed
>> > purpose such as being connected to audio hardware (e.g. mpc8610_hpcd.dts
>> > where some channels are "fsl,ssi-dma-channel").
>>
>> That sounds terribly like encoding policy into DT rather than it being a
>> HW description.
>
> It is hardware description.  Those DMA channels are physically wired
> into the audio hardware.  Other DMA channels in the same system aren't.

Well, not quite.  Technically the DMA channel can be dynamically
assigned to the SSI, but there are limits.  At the time the code was
written, there was no way to reserve a DMA channel from the generic
DMA driver, and I didn't want to have to depend on that driver either.
 Using the device tree forced a specific pair of channels to be
assigned to each SSI.  The audio driver has code to program the SoC to
route whichever DMA channels are assigned, but it assumes that the
device tree has a valid assignment.

I believe the generic DMA driver can now accept DMA channel
reservations, but I don't think it works both ways.  That is, if the
audio driver loads first, I don't think there's a clean way to tell
the DMA driver which channels have already been taken by the audio
driver.

  reply	other threads:[~2013-08-22  0:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 10:49 [PATCH v7 0/3] DMA: Freescale: Add support for 8-channel DMA engine hongbo.zhang
2013-07-29 10:49 ` [PATCH v7 1/3] DMA: Freescale: revise device tree binding document hongbo.zhang
2013-07-29 22:09   ` Scott Wood
2013-08-21 22:33   ` Stephen Warren
2013-08-21 22:45     ` Scott Wood
2013-08-21 23:12       ` Stephen Warren
2013-08-21 23:33         ` Scott Wood
2013-07-29 10:49 ` [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes hongbo.zhang
2013-07-29 22:10   ` Scott Wood
2013-07-30  2:10     ` Hongbo Zhang
2013-08-21 22:40   ` Stephen Warren
2013-08-21 22:57     ` Scott Wood
2013-08-21 23:15       ` Stephen Warren
2013-08-21 23:31         ` Scott Wood
2013-08-22  0:27           ` Timur Tabi [this message]
2013-08-21 23:00     ` Scott Wood
2013-08-21 23:16       ` Stephen Warren
2013-08-23  3:17         ` Hongbo Zhang
2013-08-26 10:33           ` Hongbo Zhang
2013-07-29 10:49 ` [PATCH v7 3/3] DMA: Freescale: update driver to support 8-channel DMA engine hongbo.zhang
2013-07-29 10:59 ` [PATCH v7 0/3] DMA: Freescale: Add support for " Vinod Koul
2013-07-30  2:08   ` Hongbo Zhang
2013-08-20  8:33   ` Hongbo Zhang
2013-08-20  8:15     ` Vinod Koul
2013-08-21  6:59       ` Hongbo Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOZdJXXvyFQZqyKjDerESB7RmZ9J76R40xLtNGfTd1Wv=W-bow@mail.gmail.com' \
    --to=timur@tabi.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djbw@fb.com \
    --cc=hongbo.zhang@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=swarren@wwwdotorg.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).