* [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings
@ 2019-06-05 20:53 Qian Cai
2019-06-27 19:52 ` Qian Cai
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-06-05 20:53 UTC (permalink / raw)
To: mpe; +Cc: linux-kernel, Qian Cai, tyreld, paulus, linuxppc-dev
At the beginning of setup_64.c, it has,
#ifdef DEBUG
#define DBG(fmt...) udbg_printf(fmt)
#else
#define DBG(fmt...)
#endif
where DBG() could be compiled away, and generate warnings,
arch/powerpc/kernel/setup_64.c: In function 'initialize_cache_info':
arch/powerpc/kernel/setup_64.c:579:49: warning: suggest braces around
empty body in an 'if' statement [-Wempty-body]
DBG("Argh, can't find dcache properties !\n");
^
arch/powerpc/kernel/setup_64.c:582:49: warning: suggest braces around
empty body in an 'if' statement [-Wempty-body]
DBG("Argh, can't find icache properties !\n");
Suggested-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Qian Cai <cai@lca.pw>
---
v2: fix it by using a NOP while loop.
arch/powerpc/kernel/setup_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 44b4c432a273..bed4ae8d338c 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -71,7 +71,7 @@
#ifdef DEBUG
#define DBG(fmt...) udbg_printf(fmt)
#else
-#define DBG(fmt...)
+#define DBG(fmt...) do { } while (0)
#endif
int spinning_secondaries;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings
2019-06-05 20:53 [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings Qian Cai
@ 2019-06-27 19:52 ` Qian Cai
2019-06-27 20:08 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-06-27 19:52 UTC (permalink / raw)
To: mpe; +Cc: linuxppc-dev, paulus, tyreld, linux-kernel
Ping.
On Wed, 2019-06-05 at 16:53 -0400, Qian Cai wrote:
> At the beginning of setup_64.c, it has,
>
> #ifdef DEBUG
> #define DBG(fmt...) udbg_printf(fmt)
> #else
> #define DBG(fmt...)
> #endif
>
> where DBG() could be compiled away, and generate warnings,
>
> arch/powerpc/kernel/setup_64.c: In function 'initialize_cache_info':
> arch/powerpc/kernel/setup_64.c:579:49: warning: suggest braces around
> empty body in an 'if' statement [-Wempty-body]
> DBG("Argh, can't find dcache properties !\n");
> ^
> arch/powerpc/kernel/setup_64.c:582:49: warning: suggest braces around
> empty body in an 'if' statement [-Wempty-body]
> DBG("Argh, can't find icache properties !\n");
>
> Suggested-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>
> v2: fix it by using a NOP while loop.
>
> arch/powerpc/kernel/setup_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 44b4c432a273..bed4ae8d338c 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -71,7 +71,7 @@
> #ifdef DEBUG
> #define DBG(fmt...) udbg_printf(fmt)
> #else
> -#define DBG(fmt...)
> +#define DBG(fmt...) do { } while (0)
> #endif
>
> int spinning_secondaries;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings
2019-06-27 19:52 ` Qian Cai
@ 2019-06-27 20:08 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2019-06-27 20:08 UTC (permalink / raw)
To: Qian Cai, mpe; +Cc: linuxppc-dev, paulus, tyreld, linux-kernel
On Thu, 2019-06-27 at 15:52 -0400, Qian Cai wrote:
> On Wed, 2019-06-05 at 16:53 -0400, Qian Cai wrote:
> > At the beginning of setup_64.c, it has,
> >
> > #ifdef DEBUG
> > #define DBG(fmt...) udbg_printf(fmt)
> > #else
> > #define DBG(fmt...)
> > #endif
> >
> > where DBG() could be compiled away, and generate warnings,
> >
> > arch/powerpc/kernel/setup_64.c: In function 'initialize_cache_info':
> > arch/powerpc/kernel/setup_64.c:579:49: warning: suggest braces around
> > empty body in an 'if' statement [-Wempty-body]
> > DBG("Argh, can't find dcache properties !\n");
> > ^
> > arch/powerpc/kernel/setup_64.c:582:49: warning: suggest braces around
> > empty body in an 'if' statement [-Wempty-body]
> > DBG("Argh, can't find icache properties !\n");
[]
> > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
[]
> > @@ -71,7 +71,7 @@
> > #ifdef DEBUG
> > #define DBG(fmt...) udbg_printf(fmt)
> > #else
> > -#define DBG(fmt...)
> > +#define DBG(fmt...) do { } while (0)
I suggest
#define DBG(fmt...) do { if (0) udbg_printf(fmt); } while (0)
so that format and argument are always verified by the compiler.
I would also prefer a more generic form using ##__VA_ARGS__
#ifdef DEBUG
#define DBG(fmt, ...) udbg_printf(fmt, ##__VA_ARGS__)
#else
#define DBG(fmt, ...) do { if (0) udbg_printf(fmt, ##__VA_ARGS__); } while (0)
#endif
or maybe use the no_printk macro like
#ifdef DEBUG
#define DBG(fmt, ...) udbg_printf(fmt, ##__VA_ARGS__)
#else
#define DBG(fmt, ...) no_printk(fmt, ##__VA_ARGS__)
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-27 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 20:53 [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings Qian Cai
2019-06-27 19:52 ` Qian Cai
2019-06-27 20:08 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).