* [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags()
@ 2016-12-24 6:05 Madhavan Srinivasan
2016-12-26 4:15 ` Anshuman Khandual
2017-02-19 11:33 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Madhavan Srinivasan @ 2016-12-24 6:05 UTC (permalink / raw)
To: mpe; +Cc: linuxppc-dev, Madhavan Srinivasan
Cleanup to use is_kernel_addr macro.
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
arch/powerpc/perf/core-book3s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index 2cdf2647cdb0..d9c74fd1b37b 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -243,7 +243,7 @@ static inline u32 perf_get_misc_flags(struct pt_regs *regs)
*/
if (ppmu->flags & PPMU_NO_SIPR) {
unsigned long siar = mfspr(SPRN_SIAR);
- if (siar >= PAGE_OFFSET)
+ if (is_kernel_addr(siar))
return PERF_RECORD_MISC_KERNEL;
return PERF_RECORD_MISC_USER;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags()
2016-12-24 6:05 [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags() Madhavan Srinivasan
@ 2016-12-26 4:15 ` Anshuman Khandual
2017-01-05 11:09 ` Madhavan Srinivasan
2017-02-19 11:33 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Anshuman Khandual @ 2016-12-26 4:15 UTC (permalink / raw)
To: Madhavan Srinivasan, mpe; +Cc: linuxppc-dev
On 12/24/2016 11:35 AM, Madhavan Srinivasan wrote:
> Cleanup to use is_kernel_addr macro.
>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
> ---
> arch/powerpc/perf/core-book3s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
> index 2cdf2647cdb0..d9c74fd1b37b 100644
> --- a/arch/powerpc/perf/core-book3s.c
> +++ b/arch/powerpc/perf/core-book3s.c
> @@ -243,7 +243,7 @@ static inline u32 perf_get_misc_flags(struct pt_regs *regs)
> */
> if (ppmu->flags & PPMU_NO_SIPR) {
> unsigned long siar = mfspr(SPRN_SIAR);
> - if (siar >= PAGE_OFFSET)
> + if (is_kernel_addr(siar))
> return PERF_RECORD_MISC_KERNEL;
> return PERF_RECORD_MISC_USER;
> }
While you are at this, why not also clean up these in the xmon code
as well.
arch/powerpc/xmon/xmon.c: if (sp < PAGE_OFFSET) {
arch/powerpc/xmon/xmon.c: if (lr < PAGE_OFFSET
arch/powerpc/xmon/xmon.c: } else if (lr >= PAGE_OFFSET
arch/powerpc/xmon/xmon.c: if (addr < PAGE_OFFSET)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags()
2016-12-26 4:15 ` Anshuman Khandual
@ 2017-01-05 11:09 ` Madhavan Srinivasan
0 siblings, 0 replies; 4+ messages in thread
From: Madhavan Srinivasan @ 2017-01-05 11:09 UTC (permalink / raw)
To: Anshuman Khandual, mpe; +Cc: linuxppc-dev
On Monday 26 December 2016 09:45 AM, Anshuman Khandual wrote:
> On 12/24/2016 11:35 AM, Madhavan Srinivasan wrote:
>> Cleanup to use is_kernel_addr macro.
>>
>> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/perf/core-book3s.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
>> index 2cdf2647cdb0..d9c74fd1b37b 100644
>> --- a/arch/powerpc/perf/core-book3s.c
>> +++ b/arch/powerpc/perf/core-book3s.c
>> @@ -243,7 +243,7 @@ static inline u32 perf_get_misc_flags(struct pt_regs *regs)
>> */
>> if (ppmu->flags & PPMU_NO_SIPR) {
>> unsigned long siar = mfspr(SPRN_SIAR);
>> - if (siar >= PAGE_OFFSET)
>> + if (is_kernel_addr(siar))
>> return PERF_RECORD_MISC_KERNEL;
>> return PERF_RECORD_MISC_USER;
>> }
> While you are at this, why not also clean up these in the xmon code
> as well.
Yes. Have handled this in a separate patch.
Maddy
> arch/powerpc/xmon/xmon.c: if (sp < PAGE_OFFSET) {
> arch/powerpc/xmon/xmon.c: if (lr < PAGE_OFFSET
> arch/powerpc/xmon/xmon.c: } else if (lr >= PAGE_OFFSET
> arch/powerpc/xmon/xmon.c: if (addr < PAGE_OFFSET)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags()
2016-12-24 6:05 [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags() Madhavan Srinivasan
2016-12-26 4:15 ` Anshuman Khandual
@ 2017-02-19 11:33 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-02-19 11:33 UTC (permalink / raw)
To: Madhavan Srinivasan; +Cc: Madhavan Srinivasan, linuxppc-dev
On Sat, 2016-12-24 at 06:05:49 UTC, Madhavan Srinivasan wrote:
> Cleanup to use is_kernel_addr macro.
>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/a2391b35f1d9d5b51d43a9150c7239
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-19 11:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-24 6:05 [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags() Madhavan Srinivasan
2016-12-26 4:15 ` Anshuman Khandual
2017-01-05 11:09 ` Madhavan Srinivasan
2017-02-19 11:33 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).