* [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant
@ 2022-02-04 9:59 Martin Povišer
2022-02-06 12:46 ` Sven Peter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Martin Povišer @ 2022-02-04 9:59 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Michael Ellerman
Cc: linux-kernel, Paul Mackerras, linux-i2c, Martin Povišer,
linuxppc-dev, Alyssa Rosenzweig
Drop I2C device-probing classes from platform variant of the PASemi
controller as it is only used on platforms where I2C devices should
be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not
raised as up to this point no devices relied on the old behavior.)
Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
I am sending v2 as some people got their copy in v1 encrypted with
their WKD keys (by accident). I changed email provider since.
drivers/i2c/busses/i2c-pasemi-core.c | 1 -
drivers/i2c/busses/i2c-pasemi-pci.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pasemi-core.c b/drivers/i2c/busses/i2c-pasemi-core.c
index 4e161a4089d8..7728c8460dc0 100644
--- a/drivers/i2c/busses/i2c-pasemi-core.c
+++ b/drivers/i2c/busses/i2c-pasemi-core.c
@@ -333,7 +333,6 @@ int pasemi_i2c_common_probe(struct pasemi_smbus *smbus)
smbus->adapter.owner = THIS_MODULE;
snprintf(smbus->adapter.name, sizeof(smbus->adapter.name),
"PA Semi SMBus adapter (%s)", dev_name(smbus->dev));
- smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
smbus->adapter.algo = &smbus_algorithm;
smbus->adapter.algo_data = smbus;
diff --git a/drivers/i2c/busses/i2c-pasemi-pci.c b/drivers/i2c/busses/i2c-pasemi-pci.c
index 1ab1f28744fb..cfc89e04eb94 100644
--- a/drivers/i2c/busses/i2c-pasemi-pci.c
+++ b/drivers/i2c/busses/i2c-pasemi-pci.c
@@ -56,6 +56,7 @@ static int pasemi_smb_pci_probe(struct pci_dev *dev,
if (!smbus->ioaddr)
return -EBUSY;
+ smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
error = pasemi_i2c_common_probe(smbus);
if (error)
return error;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant
2022-02-04 9:59 [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant Martin Povišer
@ 2022-02-06 12:46 ` Sven Peter
2022-02-06 14:17 ` Hector Martin
2022-02-15 9:31 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Sven Peter @ 2022-02-06 12:46 UTC (permalink / raw)
To: Martin Povišer
Cc: Hector Martin, linux-kernel, Paul Mackerras, linux-i2c,
linuxppc-dev, Alyssa Rosenzweig
On Fri, Feb 4, 2022, at 10:59, Martin Povišer wrote:
> Drop I2C device-probing classes from platform variant of the PASemi
> controller as it is only used on platforms where I2C devices should
> be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not
> raised as up to this point no devices relied on the old behavior.)
>
> Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver")
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant
2022-02-04 9:59 [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant Martin Povišer
2022-02-06 12:46 ` Sven Peter
@ 2022-02-06 14:17 ` Hector Martin
2022-02-15 9:31 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Hector Martin @ 2022-02-06 14:17 UTC (permalink / raw)
To: Martin Povišer, Sven Peter, Michael Ellerman
Cc: linux-kernel, Paul Mackerras, linux-i2c, linuxppc-dev, Alyssa Rosenzweig
On 04/02/2022 18.59, Martin Povišer wrote:
> Drop I2C device-probing classes from platform variant of the PASemi
> controller as it is only used on platforms where I2C devices should
> be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not
> raised as up to this point no devices relied on the old behavior.)
>
> Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver")
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Acked-by: Hector Martin <marcan@marcan.st>
Heh, so that's where this was... I remember running into this and
wondering if there was a way to turn it off.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant
2022-02-04 9:59 [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant Martin Povišer
2022-02-06 12:46 ` Sven Peter
2022-02-06 14:17 ` Hector Martin
@ 2022-02-15 9:31 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-02-15 9:31 UTC (permalink / raw)
To: Martin Povišer
Cc: Sven Peter, Hector Martin, linux-kernel, Paul Mackerras,
linux-i2c, linuxppc-dev, Alyssa Rosenzweig
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Fri, Feb 04, 2022 at 10:59:14AM +0100, Martin Povišer wrote:
> Drop I2C device-probing classes from platform variant of the PASemi
> controller as it is only used on platforms where I2C devices should
> be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not
> raised as up to this point no devices relied on the old behavior.)
>
> Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver")
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-15 9:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 9:59 [PATCH v2] i2c: pasemi: Drop I2C classes from platform driver variant Martin Povišer
2022-02-06 12:46 ` Sven Peter
2022-02-06 14:17 ` Hector Martin
2022-02-15 9:31 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).