linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Kees Cook <keescook@chromium.org>
Cc: linuxppc-dev@ozlabs.org, maddy@linux.ibm.com,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS
Date: Thu, 11 Oct 2018 11:32:46 +1100	[thread overview]
Message-ID: <874ldt2uhd.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <CAGXu5jJqX6ogFgX1q9czwWtufK_nvzUnfN3Xf-74eOBOpcXWVg@mail.gmail.com>

Kees Cook <keescook@chromium.org> writes:
> On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Warn whenever a switch statement has a fallthrough without a comment
>> annotating it.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Yes please. :)
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Haha, thanks.

It still pops a few errors, including in linux/signal.h & compat.h, so
it's somewhat aspirational until we can get those fixed up :)

cheers

  reply	other threads:[~2018-10-11  0:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  5:13 [PATCH 1/4] powerpc: Move core kernel logic into arch/powerpc/Kbuild Michael Ellerman
2018-10-10  5:13 ` [PATCH 2/4] powerpc: Add -Werror at arch/powerpc level Michael Ellerman
2018-10-19  2:51   ` [2/4] " Michael Ellerman
2018-10-10  5:13 ` [PATCH 3/4] powerpc: Add -Wvla to arch CFLAGS Michael Ellerman
2018-10-10 14:45   ` Kees Cook
2018-10-11  0:30     ` Michael Ellerman
2018-10-10  5:13 ` [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough " Michael Ellerman
2018-10-10 14:47   ` Kees Cook
2018-10-11  0:32     ` Michael Ellerman [this message]
2018-10-11  1:35       ` Kees Cook
2018-10-11 13:11         ` Gustavo A. R. Silva
2018-10-11 15:23       ` Gustavo A. R. Silva
2018-10-12  9:32         ` Michael Ellerman
2018-10-12  9:59           ` Gustavo A. R. Silva
2018-10-13  1:23             ` Kees Cook
2018-10-13  7:39               ` Gustavo A. R. Silva
2018-10-10 16:55   ` kbuild test robot
2018-10-10 17:00   ` kbuild test robot
2018-10-19  2:51 ` [1/4] powerpc: Move core kernel logic into arch/powerpc/Kbuild Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ldt2uhd.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=maddy@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).