From: Kees Cook <keescook@chromium.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, maddy@linux.ibm.com,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS
Date: Wed, 10 Oct 2018 07:47:05 -0700 [thread overview]
Message-ID: <CAGXu5jJqX6ogFgX1q9czwWtufK_nvzUnfN3Xf-74eOBOpcXWVg@mail.gmail.com> (raw)
In-Reply-To: <20181010051308.25422-4-mpe@ellerman.id.au>
On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Warn whenever a switch statement has a fallthrough without a comment
> annotating it.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Yes please. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> arch/powerpc/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild
> index 86b261d6bde5..ef625f1db576 100644
> --- a/arch/powerpc/Kbuild
> +++ b/arch/powerpc/Kbuild
> @@ -1,4 +1,5 @@
> subdir-ccflags-y := $(call cc-option, -Wvla)
> +subdir-ccflags-y += $(call cc-option, -Wimplicit-fallthrough)
> subdir-ccflags-$(CONFIG_PPC_WERROR) += -Werror
>
> obj-y += kernel/
> --
> 2.17.1
>
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2018-10-10 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 5:13 [PATCH 1/4] powerpc: Move core kernel logic into arch/powerpc/Kbuild Michael Ellerman
2018-10-10 5:13 ` [PATCH 2/4] powerpc: Add -Werror at arch/powerpc level Michael Ellerman
2018-10-19 2:51 ` [2/4] " Michael Ellerman
2018-10-10 5:13 ` [PATCH 3/4] powerpc: Add -Wvla to arch CFLAGS Michael Ellerman
2018-10-10 14:45 ` Kees Cook
2018-10-11 0:30 ` Michael Ellerman
2018-10-10 5:13 ` [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough " Michael Ellerman
2018-10-10 14:47 ` Kees Cook [this message]
2018-10-11 0:32 ` Michael Ellerman
2018-10-11 1:35 ` Kees Cook
2018-10-11 13:11 ` Gustavo A. R. Silva
2018-10-11 15:23 ` Gustavo A. R. Silva
2018-10-12 9:32 ` Michael Ellerman
2018-10-12 9:59 ` Gustavo A. R. Silva
2018-10-13 1:23 ` Kees Cook
2018-10-13 7:39 ` Gustavo A. R. Silva
2018-10-10 16:55 ` kbuild test robot
2018-10-10 17:00 ` kbuild test robot
2018-10-19 2:51 ` [1/4] powerpc: Move core kernel logic into arch/powerpc/Kbuild Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJqX6ogFgX1q9czwWtufK_nvzUnfN3Xf-74eOBOpcXWVg@mail.gmail.com \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).