linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/pseries: Switch to GFP_ATOMIC allocations in hotplug interrupt handler
@ 2019-06-12 14:21 Bharata B Rao
  2019-06-12 16:38 ` Nathan Lynch
  0 siblings, 1 reply; 2+ messages in thread
From: Bharata B Rao @ 2019-06-12 14:21 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: aneesh.kumar, Bharata B Rao

queue_hotplug_event() gets called from interrupt handler code. Use
GFP_ATOMIC allocations instead of GFP_KERNEL.

Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/dlpar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
index 17958043e7f7..79b36d91be28 100644
--- a/arch/powerpc/platforms/pseries/dlpar.c
+++ b/arch/powerpc/platforms/pseries/dlpar.c
@@ -387,10 +387,10 @@ void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog)
 	struct pseries_hp_errorlog *hp_errlog_copy;
 
 	hp_errlog_copy = kmalloc(sizeof(struct pseries_hp_errorlog),
-				 GFP_KERNEL);
+				 GFP_ATOMIC);
 	memcpy(hp_errlog_copy, hp_errlog, sizeof(struct pseries_hp_errorlog));
 
-	work = kmalloc(sizeof(struct pseries_hp_work), GFP_KERNEL);
+	work = kmalloc(sizeof(struct pseries_hp_work), GFP_ATOMIC);
 	if (work) {
 		INIT_WORK((struct work_struct *)work, pseries_hp_work_fn);
 		work->errlog = hp_errlog_copy;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/pseries: Switch to GFP_ATOMIC allocations in hotplug interrupt handler
  2019-06-12 14:21 [PATCH] powerpc/pseries: Switch to GFP_ATOMIC allocations in hotplug interrupt handler Bharata B Rao
@ 2019-06-12 16:38 ` Nathan Lynch
  0 siblings, 0 replies; 2+ messages in thread
From: Nathan Lynch @ 2019-06-12 16:38 UTC (permalink / raw)
  To: Bharata B Rao; +Cc: linuxppc-dev, aneesh.kumar

Bharata B Rao <bharata@linux.ibm.com> writes:

> queue_hotplug_event() gets called from interrupt handler code. Use
> GFP_ATOMIC allocations instead of GFP_KERNEL.

https://patchwork.ozlabs.org/patch/1106626/

(That version also adds a missing check for the result of the first
kmalloc.)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-12 16:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 14:21 [PATCH] powerpc/pseries: Switch to GFP_ATOMIC allocations in hotplug interrupt handler Bharata B Rao
2019-06-12 16:38 ` Nathan Lynch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).