linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
	Michael Bringmann <mwb@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: John Allen <jallen@linux.vnet.ibm.com>,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
	Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Subject: Re: [PATCH V7 1/3] powerpc/nodes: Ensure enough nodes avail for operations
Date: Wed, 22 Nov 2017 22:17:04 +1100	[thread overview]
Message-ID: <87lgiy36mn.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <2a2ded0a-333f-ae8b-cb4a-94a137550fbf@linux.vnet.ibm.com>

Nathan Fontenot <nfont@linux.vnet.ibm.com> writes:
> On 11/16/2017 11:24 AM, Michael Bringmann wrote:
...
>> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
>> index eb604b3..334a1ff 100644
>> --- a/arch/powerpc/mm/numa.c
>> +++ b/arch/powerpc/mm/numa.c
>> @@ -892,6 +892,37 @@ static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)
>>  	NODE_DATA(nid)->node_spanned_pages = spanned_pages;
>>  }
>> 
>> +static void __init find_possible_nodes(void)
>> +{
>> +	struct device_node *rtas;
>> +	u32 numnodes, i;
>> +
>> +	if (min_common_depth <= 0)
>> +		return;
>> +
>> +	rtas = of_find_node_by_path("/rtas");
>> +	if (!rtas)
>> +		return;
>> +
>> +	if (of_property_read_u32_index(rtas,
>> +				"ibm,max-associativity-domains",
>> +				min_common_depth, &numnodes))
>> +		goto out;
>> +
>> +	pr_info("numa: Nodes = %d (mcd = %d)\n", numnodes,
>> +		min_common_depth);
>
> numa.c already has a pr_fmt define, no need to pre-pend "numa:" to the
> information message.

And in fact no need to print that out here at all, it's covered
elsewhere. So just drop that pr_info() entirely.

cheers

  reply	other threads:[~2017-11-22 11:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 17:24 [PATCH V7 0/2] powerpc/nodes: Fix issues with memoryless nodes Michael Bringmann
2017-11-16 17:24 ` [PATCH V7 1/3] powerpc/nodes: Ensure enough nodes avail for operations Michael Bringmann
2017-11-20 16:33   ` Nathan Fontenot
2017-11-22 11:17     ` Michael Ellerman [this message]
2017-11-27 20:02       ` Michael Bringmann
2017-11-27 20:02     ` Michael Bringmann
2017-11-16 17:24 ` [PATCH V7 2/3] poserpc/initnodes: Ensure nodes initialized for hotplug Michael Bringmann
2017-11-16 17:27 ` RESEND " Michael Bringmann
2017-11-20 16:45   ` Nathan Fontenot
2017-11-27 20:16     ` Michael Bringmann
2017-11-16 17:28 ` [PATCH V7 3/3] hotplug/cpu: Fix crash with memoryless nodes Michael Bringmann
2017-11-20 16:50   ` Nathan Fontenot
2017-11-27 20:36     ` Michael Bringmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgiy36mn.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mwb@linux.vnet.ibm.com \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=tlfalcon@linux.vnet.ibm.com \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).