Re: [PATCH V7 1/3] powerpc/nodes: Ensure enough nodes avail for operations

[Michael Bringmann <mwb@linux.vnet.ibm.com>]

See below.

On 11/22/2017 05:17 AM, Michael Ellerman wrote:
> Nathan Fontenot <nfont@linux.vnet.ibm.com> writes:
>> On 11/16/2017 11:24 AM, Michael Bringmann wrote:
> ...
>>> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
>>> index eb604b3..334a1ff 100644
>>> --- a/arch/powerpc/mm/numa.c
>>> +++ b/arch/powerpc/mm/numa.c
>>> @@ -892,6 +892,37 @@ static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)
>>>  	NODE_DATA(nid)->node_spanned_pages = spanned_pages;
>>>  }
>>>
>>> +static void __init find_possible_nodes(void)
>>> +{
>>> +	struct device_node *rtas;
>>> +	u32 numnodes, i;
>>> +
>>> +	if (min_common_depth <= 0)
>>> +		return;
>>> +
>>> +	rtas = of_find_node_by_path("/rtas");
>>> +	if (!rtas)
>>> +		return;
>>> +
>>> +	if (of_property_read_u32_index(rtas,
>>> +				"ibm,max-associativity-domains",
>>> +				min_common_depth, &numnodes))
>>> +		goto out;
>>> +
>>> +	pr_info("numa: Nodes = %d (mcd = %d)\n", numnodes,
>>> +		min_common_depth);
>>
>> numa.c already has a pr_fmt define, no need to pre-pend "numa:" to the
>> information message.
> 
> And in fact no need to print that out here at all, it's covered
> elsewhere. So just drop that pr_info() entirely.
> 
> cheers
> 
> 

Okay.  pr_info() removed.

-- 
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line  363-5196
External: (512) 286-5196
Cell:       (512) 466-0650
mwb@linux.vnet.ibm.com