From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Michael Bringmann <mwb@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Juliet Kim <minkim@us.ibm.com>,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Subject: Re: [PATCH v03 1/5] powerpc/drmem: Export 'dynamic-memory' loader
Date: Tue, 09 Oct 2018 22:19:55 +1100 [thread overview]
Message-ID: <87o9c31i5g.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <3dde35eb-4997-5d61-c94f-d036bd57de18@linux.vnet.ibm.com>
Nathan Fontenot <nfont@linux.vnet.ibm.com> writes:
> On 10/02/2018 08:00 PM, Michael Ellerman wrote:
>> Michael Bringmann <mwb@linux.vnet.ibm.com> writes:
>>
>>> powerpc/drmem: Export many of the functions of DRMEM to parse
>>> "ibm,dynamic-memory" and "ibm,dynamic-memory-v2" during hotplug
>>> operations and for Post Migration events.
>>
>> This isn't a criticism of your patch, but I think the drmem.c code
>> should be moved into platforms/pseries.
>>
>> That would then make most of it private to platforms/pseries and we
>> wouldn't need to export things in arch/powerpc/include/asm.
>
> I don't have an issue with moving it to platform/pseries. I originally
> put it in arch/powerpc/mm because the numa code also uses the drmem code.
Yeah, originally the NUMA code was only used on pseries so the
distinction between NUMA and pseries-specific NUMA didn't exist.
But these days we're getting more and more code that is really pseries
(or PAPR) specific, so it might make sense to move it.
I may be wrong, perhaps there isn't a clean split there, but it would be
worth trying.
cheers
next prev parent reply other threads:[~2018-10-09 11:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 12:59 [PATCH v03 0/5] powerpc/migration: Affinity fix for memory Michael Bringmann
2018-10-01 12:59 ` [PATCH v03 1/5] powerpc/drmem: Export 'dynamic-memory' loader Michael Bringmann
2018-10-02 20:56 ` Tyrel Datwyler
2018-10-03 13:22 ` Michael Bringmann
2018-10-03 1:00 ` Michael Ellerman
2018-10-04 2:24 ` Nathan Fontenot
2018-10-09 11:19 ` Michael Ellerman [this message]
2018-10-01 12:59 ` [PATCH v03 2/5] powerpc/drmem: Add internal_flags feature Michael Bringmann
2018-10-01 12:59 ` [PATCH v03 3/5] migration/memory: Add hotplug READD_MULTIPLE Michael Bringmann
2018-10-02 21:03 ` Tyrel Datwyler
2018-10-03 13:31 ` Michael Bringmann
2018-10-01 13:00 ` [PATCH v03 4/5] migration/memory: Evaluate LMB assoc changes Michael Bringmann
2018-10-02 21:08 ` Tyrel Datwyler
2018-10-03 14:21 ` Michael Bringmann
2018-10-01 13:00 ` [PATCH v03 5/5] migration/memory: Support 'ibm,dynamic-memory-v2' Michael Bringmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9c31i5g.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minkim@us.ibm.com \
--cc=mwb@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).