From: Michael Bringmann <mwb@linux.vnet.ibm.com>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Juliet Kim <minkim@us.ibm.com>,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Subject: Re: [PATCH v03 3/5] migration/memory: Add hotplug READD_MULTIPLE
Date: Wed, 3 Oct 2018 08:31:03 -0500 [thread overview]
Message-ID: <ff3ce485-8f4a-571d-91c4-9b62ae4c98fe@linux.vnet.ibm.com> (raw)
In-Reply-To: <460b921e-269b-c7d2-9a31-522a1674faec@linux.vnet.ibm.com>
On 10/02/2018 04:03 PM, Tyrel Datwyler wrote:
> On 10/01/2018 05:59 AM, Michael Bringmann wrote:
>> migration/memory: This patch adds a new pseries hotplug action
>> for CPU and memory operations, PSERIES_HP_ELOG_ACTION_READD_MULTIPLE.
>> This is a variant of the READD operation which performs the action
>> upon multiple instances of the resource at one time. The operation
>> is to be triggered by device-tree analysis of updates by RTAS events
>> analyzed by 'migation_store' during post-migration processing. It
>> will be used for memory updates, initially.
>>
>> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/include/asm/rtas.h | 1 +
>> arch/powerpc/mm/drmem.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
>> index 71e393c..e510d82 100644
>> --- a/arch/powerpc/include/asm/rtas.h
>> +++ b/arch/powerpc/include/asm/rtas.h
>> @@ -320,6 +320,7 @@ struct pseries_hp_errorlog {
>> #define PSERIES_HP_ELOG_ACTION_ADD 1
>> #define PSERIES_HP_ELOG_ACTION_REMOVE 2
>> #define PSERIES_HP_ELOG_ACTION_READD 3
>> +#define PSERIES_HP_ELOG_ACTION_READD_MULTIPLE 4
>
> I'm confused, you have only added a define and not the actual implementation. I really think this should be squashed into your 4th patch where the operation is actually implemented.
Okay.
>
>>
>> #define PSERIES_HP_ELOG_ID_DRC_NAME 1
>> #define PSERIES_HP_ELOG_ID_DRC_INDEX 2
>> diff --git a/arch/powerpc/mm/drmem.c b/arch/powerpc/mm/drmem.c
>> index fd2cae92..2228586 100644
>> --- a/arch/powerpc/mm/drmem.c
>> +++ b/arch/powerpc/mm/drmem.c
>> @@ -422,6 +422,7 @@ static void init_drmem_v2_lmbs(const __be32 *prop,
>>
>> lmb->aa_index = dr_cell.aa_index;
>> lmb->flags = dr_cell.flags;
>> + lmb->internal_flags = 0;
>
> And this should have been squashed into the previous patch where you added the internal_flags field to the lmb struct.
Okay.
>
> -Tyrel
>
>> }
>> }
>> }
>>
>
>
--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
mwb@linux.vnet.ibm.com
next prev parent reply other threads:[~2018-10-03 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 12:59 [PATCH v03 0/5] powerpc/migration: Affinity fix for memory Michael Bringmann
2018-10-01 12:59 ` [PATCH v03 1/5] powerpc/drmem: Export 'dynamic-memory' loader Michael Bringmann
2018-10-02 20:56 ` Tyrel Datwyler
2018-10-03 13:22 ` Michael Bringmann
2018-10-03 1:00 ` Michael Ellerman
2018-10-04 2:24 ` Nathan Fontenot
2018-10-09 11:19 ` Michael Ellerman
2018-10-01 12:59 ` [PATCH v03 2/5] powerpc/drmem: Add internal_flags feature Michael Bringmann
2018-10-01 12:59 ` [PATCH v03 3/5] migration/memory: Add hotplug READD_MULTIPLE Michael Bringmann
2018-10-02 21:03 ` Tyrel Datwyler
2018-10-03 13:31 ` Michael Bringmann [this message]
2018-10-01 13:00 ` [PATCH v03 4/5] migration/memory: Evaluate LMB assoc changes Michael Bringmann
2018-10-02 21:08 ` Tyrel Datwyler
2018-10-03 14:21 ` Michael Bringmann
2018-10-01 13:00 ` [PATCH v03 5/5] migration/memory: Support 'ibm,dynamic-memory-v2' Michael Bringmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff3ce485-8f4a-571d-91c4-9b62ae4c98fe@linux.vnet.ibm.com \
--to=mwb@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minkim@us.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).