linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property
@ 2017-10-17 13:01 Fabio Estevam
  2017-12-01 16:22 ` Fabio Estevam
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2017-10-17 13:01 UTC (permalink / raw)
  To: mpe; +Cc: paulus, benh, robh+dt, festevam, linuxppc-dev, Fabio Estevam

'interrupts-parent' property does not exist. Fix the typo.

Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS")
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/powerpc/boot/dts/acadia.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/boot/dts/acadia.dts b/arch/powerpc/boot/dts/acadia.dts
index 57291f6..8626615 100644
--- a/arch/powerpc/boot/dts/acadia.dts
+++ b/arch/powerpc/boot/dts/acadia.dts
@@ -183,7 +183,7 @@
 			usb@ef603000 {
 				compatible = "ohci-be";
 				reg = <0xef603000 0x80>;
-				interrupts-parent = <&UIC0>;
+				interrupt-parent = <&UIC0>;
 				interrupts = <0xd 0x4 0xe 0x4>;
 			};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property
  2017-10-17 13:01 [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property Fabio Estevam
@ 2017-12-01 16:22 ` Fabio Estevam
  2017-12-04  4:45   ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2017-12-01 16:22 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: paulus, Benjamin Herrenschmidt, robh+dt, linuxppc-dev, Fabio Estevam

Hi Michael,

On Tue, Oct 17, 2017 at 11:01 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
> 'interrupts-parent' property does not exist. Fix the typo.
>
> Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/powerpc/boot/dts/acadia.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/boot/dts/acadia.dts b/arch/powerpc/boot/dts/acadia.dts
> index 57291f6..8626615 100644
> --- a/arch/powerpc/boot/dts/acadia.dts
> +++ b/arch/powerpc/boot/dts/acadia.dts
> @@ -183,7 +183,7 @@
>                         usb@ef603000 {
>                                 compatible = "ohci-be";
>                                 reg = <0xef603000 0x80>;
> -                               interrupts-parent = <&UIC0>;
> +                               interrupt-parent = <&UIC0>;

Any comments?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property
  2017-12-01 16:22 ` Fabio Estevam
@ 2017-12-04  4:45   ` Michael Ellerman
  2017-12-04  9:16     ` Fabio Estevam
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2017-12-04  4:45 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: paulus, Benjamin Herrenschmidt, robh+dt, linuxppc-dev, Fabio Estevam

Fabio Estevam <festevam@gmail.com> writes:

> Hi Michael,
>
> On Tue, Oct 17, 2017 at 11:01 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
>> 'interrupts-parent' property does not exist. Fix the typo.
>>
>> Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS")
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>> ---
>>  arch/powerpc/boot/dts/acadia.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/boot/dts/acadia.dts b/arch/powerpc/boot/dts/acadia.dts
>> index 57291f6..8626615 100644
>> --- a/arch/powerpc/boot/dts/acadia.dts
>> +++ b/arch/powerpc/boot/dts/acadia.dts
>> @@ -183,7 +183,7 @@
>>                         usb@ef603000 {
>>                                 compatible = "ohci-be";
>>                                 reg = <0xef603000 0x80>;
>> -                               interrupts-parent = <&UIC0>;
>> +                               interrupt-parent = <&UIC0>;
>
> Any comments?

Nope :)

Will pick it up for 4.16.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property
  2017-12-04  4:45   ` Michael Ellerman
@ 2017-12-04  9:16     ` Fabio Estevam
  2017-12-06 11:00       ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2017-12-04  9:16 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: paulus, Benjamin Herrenschmidt, robh+dt, linuxppc-dev, Fabio Estevam

Hi Michael,

On Mon, Dec 4, 2017 at 2:45 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:

> Will pick it up for 4.16.

Just realized that there is already a fix for this in linux-next:

commit 3d2d4339cc326c427638daa67e264dd455ee1899
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Date:   Fri Jun 2 14:38:47 2017 +0200

    powerpc: dts: acadia: DT fix s/#interrupts-parent/#interrupt-parent/

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property
  2017-12-04  9:16     ` Fabio Estevam
@ 2017-12-06 11:00       ` Michael Ellerman
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2017-12-06 11:00 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: paulus, Benjamin Herrenschmidt, robh+dt, linuxppc-dev, Fabio Estevam

Fabio Estevam <festevam@gmail.com> writes:

> Hi Michael,
>
> On Mon, Dec 4, 2017 at 2:45 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> Will pick it up for 4.16.
>
> Just realized that there is already a fix for this in linux-next:
>
> commit 3d2d4339cc326c427638daa67e264dd455ee1899
> Author: Geert Uytterhoeven <geert+renesas@glider.be>
> Date:   Fri Jun 2 14:38:47 2017 +0200
>
>     powerpc: dts: acadia: DT fix s/#interrupts-parent/#interrupt-parent/
>
>     Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>     Acked-by: Rob Herring <robh@kernel.org>
>     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>


Actually it's in mainline - because I merged it!

OK, I was a bit confused for a while there. But it's just that you and
Geert have both sent a fix for the same issue, and I merged his fix.

Sorry for the confusion.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-12-06 11:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 13:01 [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property Fabio Estevam
2017-12-01 16:22 ` Fabio Estevam
2017-12-04  4:45   ` Michael Ellerman
2017-12-04  9:16     ` Fabio Estevam
2017-12-06 11:00       ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).