From: Michael Ellerman <mpe@ellerman.id.au>
To: Matt Brown <matthew.brown.dev@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-raid@vger.kernel.org, dja@axtens.net
Subject: Re: [PATCH 1/2] lib/raid6: Build proper files on corresponding arch
Date: Wed, 12 Apr 2017 17:01:01 +1000 [thread overview]
Message-ID: <87wpaqt8ia.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170412013552.21650-1-matthew.brown.dev@gmail.com>
Matt Brown <matthew.brown.dev@gmail.com> writes:
> diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
> index 9c333e9..62b26d1 100644
> --- a/lib/raid6/test/Makefile
> +++ b/lib/raid6/test/Makefile
> @@ -44,10 +44,12 @@ else ifeq ($(HAS_NEON),yes)
> CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
> else
> HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
> - gcc -c -x c - >&/dev/null && \
> - rm ./-.o && echo yes)
> + gcc -c -x c - >/dev/null && rm ./-.o && echo yes)
> ifeq ($(HAS_ALTIVEC),yes)
> - OBJS += altivec1.o altivec2.o altivec4.o altivec8.o
> + CFLAGS += -I../../../arch/powerpc/include
> + CFLAGS += -DCONFIG_ALTIVEC
> + OBJS += altivec1.o altivec2.o altivec4.o altivec8.o \
> + vpermxor1.o vpermxor2.o vpermxor4.o vpermxor8.o
The whitespace in here is a bit of a mess, but you should follow what's
there and use spaces to indent your additions.
cheers
next prev parent reply other threads:[~2017-04-12 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 1:35 [PATCH 1/2] lib/raid6: Build proper files on corresponding arch Matt Brown
2017-04-12 1:35 ` [PATCH v3 2/2] raid6/altivec: Add vpermxor implementation for raid6 Q syndrome Matt Brown
2017-04-12 7:01 ` Michael Ellerman [this message]
2017-04-12 9:27 ` [PATCH 1/2] lib/raid6: Build proper files on corresponding arch Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpaqt8ia.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=dja@axtens.net \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.brown.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).