LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment
@ 2021-04-16 12:57 Ganesh Goudar
  2021-04-17 12:36 ` Michael Ellerman
  2021-04-21 13:08 ` Michael Ellerman
  0 siblings, 2 replies; 5+ messages in thread
From: Ganesh Goudar @ 2021-04-16 12:57 UTC (permalink / raw)
  To: linuxppc-dev, mpe; +Cc: Ganesh Goudar, mahesh, npiggin

The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.

Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/ras.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index f8b390a9d9fb..9d4ef65da7f3 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs,
 		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
 		break;
 	case MC_ERROR_TYPE_I_CACHE:
-		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
+		mce_err.error_type = MCE_ERROR_TYPE_ICACHE;
 		break;
 	case MC_ERROR_TYPE_UNKNOWN:
 	default:
-- 
2.26.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment
  2021-04-16 12:57 [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment Ganesh Goudar
@ 2021-04-17 12:36 ` Michael Ellerman
  2021-04-19  9:29   ` Ganesh
  2021-04-21 13:08 ` Michael Ellerman
  1 sibling, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2021-04-17 12:36 UTC (permalink / raw)
  To: Ganesh Goudar, linuxppc-dev; +Cc: Ganesh Goudar, mahesh, npiggin

Ganesh Goudar <ganeshgr@linux.ibm.com> writes:
> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.

Do you mean "is ICACHE not DCACHE" ?

cheers

> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
> ---
>  arch/powerpc/platforms/pseries/ras.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index f8b390a9d9fb..9d4ef65da7f3 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs,
>  		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
>  		break;
>  	case MC_ERROR_TYPE_I_CACHE:
> -		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
> +		mce_err.error_type = MCE_ERROR_TYPE_ICACHE;
>  		break;
>  	case MC_ERROR_TYPE_UNKNOWN:
>  	default:
> -- 
> 2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment
  2021-04-17 12:36 ` Michael Ellerman
@ 2021-04-19  9:29   ` Ganesh
  2021-04-19 12:39     ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Ganesh @ 2021-04-19  9:29 UTC (permalink / raw)
  To: Michael Ellerman, linuxppc-dev; +Cc: mahesh, npiggin

On 4/17/21 6:06 PM, Michael Ellerman wrote:

> Ganesh Goudar <ganeshgr@linux.ibm.com> writes:
>> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.
> Do you mean "is ICACHE not DCACHE" ?

Right :), Should I send v2 ?

>
> cheers
>
>> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
>> ---
>>   arch/powerpc/platforms/pseries/ras.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
>> index f8b390a9d9fb..9d4ef65da7f3 100644
>> --- a/arch/powerpc/platforms/pseries/ras.c
>> +++ b/arch/powerpc/platforms/pseries/ras.c
>> @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs,
>>   		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
>>   		break;
>>   	case MC_ERROR_TYPE_I_CACHE:
>> -		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
>> +		mce_err.error_type = MCE_ERROR_TYPE_ICACHE;
>>   		break;
>>   	case MC_ERROR_TYPE_UNKNOWN:
>>   	default:
>> -- 
>> 2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment
  2021-04-19  9:29   ` Ganesh
@ 2021-04-19 12:39     ` Michael Ellerman
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2021-04-19 12:39 UTC (permalink / raw)
  To: Ganesh, linuxppc-dev; +Cc: mahesh, npiggin

Ganesh <ganeshgr@linux.ibm.com> writes:
> On 4/17/21 6:06 PM, Michael Ellerman wrote:
>
>> Ganesh Goudar <ganeshgr@linux.ibm.com> writes:
>>> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.
>> Do you mean "is ICACHE not DCACHE" ?
>
> Right :), Should I send v2 ?

No I can fix it up :)

cheers

>>> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
>>> ---
>>>   arch/powerpc/platforms/pseries/ras.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
>>> index f8b390a9d9fb..9d4ef65da7f3 100644
>>> --- a/arch/powerpc/platforms/pseries/ras.c
>>> +++ b/arch/powerpc/platforms/pseries/ras.c
>>> @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs,
>>>   		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
>>>   		break;
>>>   	case MC_ERROR_TYPE_I_CACHE:
>>> -		mce_err.error_type = MCE_ERROR_TYPE_DCACHE;
>>> +		mce_err.error_type = MCE_ERROR_TYPE_ICACHE;
>>>   		break;
>>>   	case MC_ERROR_TYPE_UNKNOWN:
>>>   	default:
>>> -- 
>>> 2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment
  2021-04-16 12:57 [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment Ganesh Goudar
  2021-04-17 12:36 ` Michael Ellerman
@ 2021-04-21 13:08 ` Michael Ellerman
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2021-04-21 13:08 UTC (permalink / raw)
  To: Ganesh Goudar, mpe, linuxppc-dev; +Cc: mahesh, npiggin

On Fri, 16 Apr 2021 18:27:50 +0530, Ganesh Goudar wrote:
> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.

Applied to powerpc/next.

[1/1] powerpc/pseries/mce: Fix a typo in error type assignment
      https://git.kernel.org/powerpc/c/864ec4d40c83365b16483d88990e7e579537635c

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 12:57 [PATCH] powerpc/pseries/mce: Fix a typo in error type assignment Ganesh Goudar
2021-04-17 12:36 ` Michael Ellerman
2021-04-19  9:29   ` Ganesh
2021-04-19 12:39     ` Michael Ellerman
2021-04-21 13:08 ` Michael Ellerman

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org
	public-inbox-index linuxppc-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git