* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
[not found] ` <CAK7LNARnkHTyAMXjPZnOxOkP_b8vc6qvYOv-wf_Fn0eaPSdpeA@mail.gmail.com>
@ 2017-06-13 10:21 ` Michael Ellerman
2017-06-13 13:10 ` Anatolij Gustschin
[not found] ` <CAK7LNAS0tkpCuCjjCe=P_Qc2Q12B-+7YgAipko5n+AoeASpQnQ@mail.gmail.com>
0 siblings, 2 replies; 6+ messages in thread
From: Michael Ellerman @ 2017-06-13 10:21 UTC (permalink / raw)
To: Masahiro Yamada, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev, Anatolij Gustschin
Cc: Masahiro Yamada, devicetree, Linux Kernel Mailing List,
Rob Herring, Mark Rutland
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> Hi
>
> (+Anatolij Gustschin <agust@denx.de>)
>
>
> Ping.
> I am not 100% sure who is responsible for this,
> but somebody, could take a look at this patch, please?
Have you tested it actually works?
It sounds reasonable, and if it behaves as you describe there is no
change in behaviour, right?
cheers
> 2017-05-24 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> Most of DT files in PowerPC use #include "..." to make pre-processor
>> include DT in the same directory, but we have 3 exceptional files
>> that use #include <...> for that.
>>
>> Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from
>> dtc_cpp_flags.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> arch/powerpc/boot/dts/ac14xx.dts | 2 +-
>> arch/powerpc/boot/dts/mpc5121ads.dts | 2 +-
>> arch/powerpc/boot/dts/pdm360ng.dts | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts
>> index 27fcabc2f857..83bcfd865167 100644
>> --- a/arch/powerpc/boot/dts/ac14xx.dts
>> +++ b/arch/powerpc/boot/dts/ac14xx.dts
>> @@ -10,7 +10,7 @@
>> */
>>
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>> / {
>> model = "ac14xx";
>> diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
>> index 75888ce2c792..73c30621429b 100644
>> --- a/arch/powerpc/boot/dts/mpc5121ads.dts
>> +++ b/arch/powerpc/boot/dts/mpc5121ads.dts
>> @@ -9,7 +9,7 @@
>> * option) any later version.
>> */
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>> / {
>> model = "mpc5121ads";
>> diff --git a/arch/powerpc/boot/dts/pdm360ng.dts b/arch/powerpc/boot/dts/pdm360ng.dts
>> index 0cec7244abe7..445b88114009 100644
>> --- a/arch/powerpc/boot/dts/pdm360ng.dts
>> +++ b/arch/powerpc/boot/dts/pdm360ng.dts
>> @@ -13,7 +13,7 @@
>> * option) any later version.
>> */
>>
>> -#include <mpc5121.dtsi>
>> +#include "mpc5121.dtsi"
>>
>> / {
>> model = "pdm360ng";
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
[not found] <1495602744-18874-1-git-send-email-yamada.masahiro@socionext.com>
[not found] ` <CAK7LNARnkHTyAMXjPZnOxOkP_b8vc6qvYOv-wf_Fn0eaPSdpeA@mail.gmail.com>
@ 2017-06-13 13:04 ` Anatolij Gustschin
1 sibling, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2017-06-13 13:04 UTC (permalink / raw)
To: Masahiro Yamada, Michael Ellerman, linuxppc-dev
Cc: Benjamin Herrenschmidt, Paul Mackerras, devicetree, linux-kernel,
Rob Herring, Mark Rutland
Hi,
On Wed, 24 May 2017 14:12:24 +0900
Masahiro Yamada yamada.masahiro@socionext.com wrote:
>Most of DT files in PowerPC use #include "..." to make pre-processor
>include DT in the same directory, but we have 3 exceptional files
>that use #include <...> for that.
>
>Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from
>dtc_cpp_flags.
>
>Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Anatolij Gustschin <agust@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
2017-06-13 10:21 ` [PATCH] powerpc: dts: use #include "..." to include local DT Michael Ellerman
@ 2017-06-13 13:10 ` Anatolij Gustschin
[not found] ` <CAK7LNAS0tkpCuCjjCe=P_Qc2Q12B-+7YgAipko5n+AoeASpQnQ@mail.gmail.com>
1 sibling, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2017-06-13 13:10 UTC (permalink / raw)
To: Michael Ellerman, Masahiro Yamada, linuxppc-dev
Cc: Benjamin Herrenschmidt, Paul Mackerras, Mark Rutland,
Rob Herring, Linux Kernel Mailing List, devicetree
On Tue, 13 Jun 2017 20:21:45 +1000
Michael Ellerman mpe@ellerman.id.au wrote:
>Masahiro Yamada <yamada.masahiro@socionext.com> writes:
...
>> Ping.
>> I am not 100% sure who is responsible for this,
>> but somebody, could take a look at this patch, please?
>
>Have you tested it actually works?
>
>It sounds reasonable, and if it behaves as you describe there is no
>change in behaviour, right?
yes, these dtbs build with this patch and I've tested with
mpc5121ads.dtb.
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
[not found] ` <CAK7LNAS0tkpCuCjjCe=P_Qc2Q12B-+7YgAipko5n+AoeASpQnQ@mail.gmail.com>
@ 2017-06-14 6:45 ` Michael Ellerman
[not found] ` <CAK7LNAQ2Ek3VEou_adaH3g8efSnJ7JgvHynzqR9Br4M+q8Mccw@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2017-06-14 6:45 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
Anatolij Gustschin, devicetree, Linux Kernel Mailing List,
Rob Herring, Mark Rutland
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2017-06-13 19:21 GMT+09:00 Michael Ellerman <mpe@ellerman.id.au>:
>> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>>>
>>> (+Anatolij Gustschin <agust@denx.de>)
>>>
>>> Ping.
>>> I am not 100% sure who is responsible for this,
>>> but somebody, could take a look at this patch, please?
>>
>> Have you tested it actually works?
>>
>> It sounds reasonable, and if it behaves as you describe there is no
>> change in behaviour, right?
>
> I do not have access to hardware,
> but it is pretty easy to test this patch.
>
> $ make O=foo ARCH=powerpc CROSS_COMPILE=powerpc-linux- dts/ac14xx.dtb
>
> gave me the DTB output.
>
> The binary comparison matched with/without this patch,
> so I am sure there is no change in behavior.
>
> Likewise for mpc5121ads and pdm360ng.
Thanks.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
[not found] ` <CAK7LNAQ2Ek3VEou_adaH3g8efSnJ7JgvHynzqR9Br4M+q8Mccw@mail.gmail.com>
@ 2017-06-21 9:48 ` Michael Ellerman
[not found] ` <CAK7LNAQBbZ7WcXN=3rxi0AQGJC8W_WKtGtmapEziLUre075J=g@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2017-06-21 9:48 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
Anatolij Gustschin, devicetree, Linux Kernel Mailing List,
Rob Herring, Mark Rutland
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2017-06-14 15:45 GMT+09:00 Michael Ellerman <mpe@ellerman.id.au>:
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> I have not seen it in linux-next yet.
>
> Who will pick it up?
In the original patch you said:
Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from
dtc_cpp_flags.
So I assumed there was a series somewhere that did that and included
this patch.
But if there isn't then I can just merge it.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: dts: use #include "..." to include local DT
[not found] ` <CAK7LNASvupxqXnwm3hyEq7iGpHyActRbYjZ3v9xyd4qpxdVmLA@mail.gmail.com>
@ 2017-07-03 12:35 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2017-07-03 12:35 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
Anatolij Gustschin, devicetree, Linux Kernel Mailing List,
Rob Herring, Mark Rutland
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> Hi Michael,
>
> Ping. Please apply this patch.
>
> I need this to clean up Makefiles in the next development cycle.
Sorry for some reason it didn't land in patchwork, so I keep forgetting
about it.
Have merged it now for 4.13.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-03 12:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1495602744-18874-1-git-send-email-yamada.masahiro@socionext.com>
[not found] ` <CAK7LNARnkHTyAMXjPZnOxOkP_b8vc6qvYOv-wf_Fn0eaPSdpeA@mail.gmail.com>
2017-06-13 10:21 ` [PATCH] powerpc: dts: use #include "..." to include local DT Michael Ellerman
2017-06-13 13:10 ` Anatolij Gustschin
[not found] ` <CAK7LNAS0tkpCuCjjCe=P_Qc2Q12B-+7YgAipko5n+AoeASpQnQ@mail.gmail.com>
2017-06-14 6:45 ` Michael Ellerman
[not found] ` <CAK7LNAQ2Ek3VEou_adaH3g8efSnJ7JgvHynzqR9Br4M+q8Mccw@mail.gmail.com>
2017-06-21 9:48 ` Michael Ellerman
[not found] ` <CAK7LNAQBbZ7WcXN=3rxi0AQGJC8W_WKtGtmapEziLUre075J=g@mail.gmail.com>
[not found] ` <CAK7LNASvupxqXnwm3hyEq7iGpHyActRbYjZ3v9xyd4qpxdVmLA@mail.gmail.com>
2017-07-03 12:35 ` Michael Ellerman
2017-06-13 13:04 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).