linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/p5040: fix dtb build warning of p5040ds.dtb
@ 2012-09-12 10:36 Shaohui Xie
  2012-09-12 20:20 ` Kumar Gala
  0 siblings, 1 reply; 2+ messages in thread
From: Shaohui Xie @ 2012-09-12 10:36 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Shaohui Xie

Device node adt7461 was wrongly added in p5040ds.dts, it should be added
into i2c instead of localbus, when build p5040ds.dtb, a warning will dump:

Warning (reg_format): "reg" property in
/localbus@ffe124000/nand@2,0/adt7461@4c has invalid length (4 bytes)
(#address-cells == 1, #size-cells == 1)

This was introduced by:

commit ea6b1ba692bcb5f6e39f409a78cf8b04fdf23baa
Author: Jia Hongtao <B38951@freescale.com>
Date:   Tue Aug 28 10:00:55 2012 +0800

    powerpc: add adt7461 thermal monitor support to applicable boards

    Add thermal monitor support to following boards:
    P1022DS, MPC8536DS, P2041RDB, P3041DS, P4080DS, P5020DS, P5040DS

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
based on next branch of http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git

 arch/powerpc/boot/dts/p5040ds.dts |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/boot/dts/p5040ds.dts b/arch/powerpc/boot/dts/p5040ds.dts
index 8165c93..860b5cc 100644
--- a/arch/powerpc/boot/dts/p5040ds.dts
+++ b/arch/powerpc/boot/dts/p5040ds.dts
@@ -95,6 +95,10 @@
 				reg = <0x68>;
 				interrupts = <0x1 0x1 0 0>;
 			};
+			adt7461@4c {
+				compatible = "adi,adt7461";
+				reg = <0x4c>;
+			};
 		};
 	};
 
@@ -146,10 +150,6 @@
 				label = "NAND Writable User area";
 				reg = <0x1f000000 0x01000000>;
 			};
-			adt7461@4c {
-				compatible = "adi,adt7461";
-				reg = <0x4c>;
-			};
 		};
 
 		board-control@3,0 {
-- 
1.6.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/p5040: fix dtb build warning of p5040ds.dtb
  2012-09-12 10:36 [PATCH] powerpc/p5040: fix dtb build warning of p5040ds.dtb Shaohui Xie
@ 2012-09-12 20:20 ` Kumar Gala
  0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2012-09-12 20:20 UTC (permalink / raw)
  To: Shaohui Xie; +Cc: linuxppc-dev


On Sep 12, 2012, at 5:36 AM, Shaohui Xie wrote:

> Device node adt7461 was wrongly added in p5040ds.dts, it should be =
added
> into i2c instead of localbus, when build p5040ds.dtb, a warning will =
dump:
>=20
> Warning (reg_format): "reg" property in
> /localbus@ffe124000/nand@2,0/adt7461@4c has invalid length (4 bytes)
> (#address-cells =3D=3D 1, #size-cells =3D=3D 1)
>=20
> This was introduced by:
>=20
> commit ea6b1ba692bcb5f6e39f409a78cf8b04fdf23baa
> Author: Jia Hongtao <B38951@freescale.com>
> Date:   Tue Aug 28 10:00:55 2012 +0800
>=20
>    powerpc: add adt7461 thermal monitor support to applicable boards
>=20
>    Add thermal monitor support to following boards:
>    P1022DS, MPC8536DS, P2041RDB, P3041DS, P4080DS, P5020DS, P5040DS
>=20
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> based on next branch of =
http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git
>=20
> arch/powerpc/boot/dts/p5040ds.dts |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

applied to next

- k=

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-12 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-12 10:36 [PATCH] powerpc/p5040: fix dtb build warning of p5040ds.dtb Shaohui Xie
2012-09-12 20:20 ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).