From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Xiongwei Song <sxwjean@me.com>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
npiggin@gmail.com, ravi.bangoria@linux.ibm.com,
mikey@neuling.org, aneesh.kumar@linux.ibm.com,
haren@linux.ibm.com
Cc: Xiongwei Song <sxwjean@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/process: Enhance readability for trap types.
Date: Sun, 28 Mar 2021 17:21:58 +0200 [thread overview]
Message-ID: <8de71b45-efea-b493-ee90-b89062e8e30f@csgroup.eu> (raw)
In-Reply-To: <20210328143545.24324-1-sxwjean@me.com>
Le 28/03/2021 à 16:35, Xiongwei Song a écrit :
> From: Xiongwei Song <sxwjean@gmail.com>
>
> Define macros to enhance the code readability on ppc trap types.
Good idea
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
> arch/powerpc/kernel/process.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 3231c2df9e26..3bbd3cf353a7 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -1451,6 +1451,10 @@ static void print_msr_bits(unsigned long val)
> #define LAST_VOLATILE 12
> #endif
>
> +#define TRAP_MC 0x200 /* Machine Check */
I think usually we use MCE, so TRAP_MCE would be better
> +#define TRAP_DSI 0x300 /* DSI exception */
> +#define TRAP_AM 0x600 /* Alignment exception */
Don't know what AM means. TRAP_ALIGN would be more explicit.
> +
The defines should go in a header file, for instance asm/ptrace.h in order to be re-used in other files.
You should do more. You can find other places to improve with:
git grep "trap ==" arch/powerpc/
git grep "TRAP(regs) ==" arch/powerpc/
> static void __show_regs(struct pt_regs *regs)
> {
> int i, trap;
> @@ -1465,7 +1469,7 @@ static void __show_regs(struct pt_regs *regs)
> trap = TRAP(regs);
> if (!trap_is_syscall(regs) && cpu_has_feature(CPU_FTR_CFAR))
> pr_cont("CFAR: "REG" ", regs->orig_gpr3);
> - if (trap == 0x200 || trap == 0x300 || trap == 0x600) {
> + if (trap == TRAP_MC || trap == TRAP_DSI || trap == TRAP_AM) {
> if (IS_ENABLED(CONFIG_4xx) || IS_ENABLED(CONFIG_BOOKE))
> pr_cont("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr);
> else
>
next prev parent reply other threads:[~2021-03-28 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 14:35 [PATCH] powerpc/process: Enhance readability for trap types Xiongwei Song
2021-03-28 15:21 ` Christophe Leroy [this message]
2021-03-28 23:11 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de71b45-efea-b493-ee90-b89062e8e30f@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=haren@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).