From: Xiongwei Song <sxwjean@me.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: ravi.bangoria@linux.ibm.com, mikey@neuling.org,
Xiongwei Song <sxwjean@gmail.com>,
haren@linux.ibm.com, linux-kernel@vger.kernel.org,
npiggin@gmail.com, paulus@samba.org, aneesh.kumar@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/process: Enhance readability for trap types.
Date: Mon, 29 Mar 2021 07:11:29 +0800 [thread overview]
Message-ID: <9C228D50-4378-4477-857A-D34D46BDEF5D@me.com> (raw)
In-Reply-To: <8de71b45-efea-b493-ee90-b89062e8e30f@csgroup.eu>
> On Mar 28, 2021, at 11:21 PM, Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 28/03/2021 à 16:35, Xiongwei Song a écrit :
>> From: Xiongwei Song <sxwjean@gmail.com>
>> Define macros to enhance the code readability on ppc trap types.
>
> Good idea
>
>> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>> ---
>> arch/powerpc/kernel/process.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
>> index 3231c2df9e26..3bbd3cf353a7 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -1451,6 +1451,10 @@ static void print_msr_bits(unsigned long val)
>> #define LAST_VOLATILE 12
>> #endif
>> +#define TRAP_MC 0x200 /* Machine Check */
>
> I think usually we use MCE, so TRAP_MCE would be better
Ok.
>
>> +#define TRAP_DSI 0x300 /* DSI exception */
>> +#define TRAP_AM 0x600 /* Alignment exception */
>
> Don't know what AM means. TRAP_ALIGN would be more explicit.
No Problem.
>
>> +
>
> The defines should go in a header file, for instance asm/ptrace.h in order to be re-used in other files.
Agree.
>
> You should do more. You can find other places to improve with:
>
> git grep "trap ==" arch/powerpc/
> git grep "TRAP(regs) ==" arch/powerpc/
Just ran “git grep”, looks like the work is much bigger than what I imagined.
>
>> static void __show_regs(struct pt_regs *regs)
>> {
>> int i, trap;
>> @@ -1465,7 +1469,7 @@ static void __show_regs(struct pt_regs *regs)
>> trap = TRAP(regs);
>> if (!trap_is_syscall(regs) && cpu_has_feature(CPU_FTR_CFAR))
>> pr_cont("CFAR: "REG" ", regs->orig_gpr3);
>> - if (trap == 0x200 || trap == 0x300 || trap == 0x600) {
>> + if (trap == TRAP_MC || trap == TRAP_DSI || trap == TRAP_AM) {
>> if (IS_ENABLED(CONFIG_4xx) || IS_ENABLED(CONFIG_BOOKE))
>> pr_cont("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr);
>> else
Thanks for the response. I will send v2.
Regards,
Xiongwei
prev parent reply other threads:[~2021-03-28 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 14:35 [PATCH] powerpc/process: Enhance readability for trap types Xiongwei Song
2021-03-28 15:21 ` Christophe Leroy
2021-03-28 23:11 ` Xiongwei Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9C228D50-4378-4477-857A-D34D46BDEF5D@me.com \
--to=sxwjean@me.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=haren@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sxwjean@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).