From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Xiubo.Lee@gmail.com>,
linuxppc-dev@lists.ozlabs.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME
Date: Mon, 20 Mar 2023 15:15:18 +0800 [thread overview]
Message-ID: <CAA+D8AMrzi7_ZBV57emtosfRVUTXzmu3KtiMaxXBRtY3G66O4w@mail.gmail.com> (raw)
In-Reply-To: <20230316123611.3495597-1-alexander.stein@ew.tq-group.com>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
On Thu, Mar 16, 2023 at 8:36 PM Alexander Stein <
alexander.stein@ew.tq-group.com> wrote:
> Instead of copying the driver name manually, use a common define.
> No functional change.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best regards
wang shengjiu
> ---
> sound/soc/fsl/fsl-asoc-card.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index cdfca9fd1eb0..e956abfd50f8 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -28,6 +28,8 @@
> #include "../codecs/wm8994.h"
> #include "../codecs/tlv320aic31xx.h"
>
> +#define DRIVER_NAME "fsl-asoc-card"
> +
> #define CS427x_SYSCLK_MCLK 0
>
> #define RX 0
> @@ -915,7 +917,7 @@ MODULE_DEVICE_TABLE(of, fsl_asoc_card_dt_ids);
> static struct platform_driver fsl_asoc_card_driver = {
> .probe = fsl_asoc_card_probe,
> .driver = {
> - .name = "fsl-asoc-card",
> + .name = DRIVER_NAME,
> .pm = &snd_soc_pm_ops,
> .of_match_table = fsl_asoc_card_dt_ids,
> },
> @@ -924,5 +926,5 @@ module_platform_driver(fsl_asoc_card_driver);
>
> MODULE_DESCRIPTION("Freescale Generic ASoC Sound Card driver with ASRC");
> MODULE_AUTHOR("Nicolin Chen <nicoleotsuka@gmail.com>");
> -MODULE_ALIAS("platform:fsl-asoc-card");
> +MODULE_ALIAS("platform:" DRIVER_NAME);
> MODULE_LICENSE("GPL");
> --
> 2.34.1
>
>
[-- Attachment #2: Type: text/html, Size: 2513 bytes --]
next prev parent reply other threads:[~2023-03-21 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 12:36 [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME Alexander Stein
2023-03-16 12:36 ` [PATCH 2/2] ASoC: fsl: Specify driver name in ASoC card Alexander Stein
2023-03-20 7:16 ` Shengjiu Wang
2023-03-20 7:15 ` Shengjiu Wang [this message]
2023-03-20 18:31 ` [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA+D8AMrzi7_ZBV57emtosfRVUTXzmu3KtiMaxXBRtY3G66O4w@mail.gmail.com \
--to=shengjiu.wang@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).