From: Li Yang <leoyang.li@nxp.com>
To: dongsheng.wang@hxt-semitech.com
Cc: Ran Wang <ran.wang_1@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] soc: fsl: add RCPM driver
Date: Tue, 4 Sep 2018 22:21:53 -0500 [thread overview]
Message-ID: <CADRPPNQN=27+pOSckxvwSuBJoFaz7pT+Z6h07Wu3Liz5ao5kkA@mail.gmail.com> (raw)
In-Reply-To: <be39f5ea8c9046b0bf1f6bbfe935fae4@HXTBJIDCEMVIW02.hxtcorp.net>
On Tue, Sep 4, 2018 at 9:58 PM Wang, Dongsheng
<dongsheng.wang@hxt-semitech.com> wrote:
>
> Please change your comments style.
Although this doesn't get into the Linux kernel coding style
documentation yet, Linus seems changed his mind to prefer // than /*
*/ comment style now. https://lkml.org/lkml/2017/11/25/133 So the
// style should be acceptable for now.
>
> On 2018/8/31 11:56, Ran Wang wrote:
> > The NXP's QorIQ Processors based on ARM Core have RCPM module (Run
> > Control and Power Management), which performs all device-level
> > tasks associated with power management such as wakeup source control.
> >
> > This driver depends on FSL platform PM driver framework which help to
> > isolate user and PM service provider (such as RCPM driver).
> >
> > Signed-off-by: Chenhui Zhao <chenhui.zhao@nxp.com>
> > Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > drivers/soc/fsl/Kconfig | 6 ++
> > drivers/soc/fsl/Makefile | 1 +
> > drivers/soc/fsl/ls-rcpm.c | 153 +++++++++++++++++++++++++++++++++++++=
++++++++
> > 3 files changed, 160 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/soc/fsl/ls-rcpm.c
> >
> > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig
> > index 6517412..882330d 100644
> > --- a/drivers/soc/fsl/Kconfig
> > +++ b/drivers/soc/fsl/Kconfig
> > @@ -30,3 +30,9 @@ config FSL_PLAT_PM
> > have to know the implement details of wakeup function it requir=
e.
> > Besides, it is also easy for service side to upgrade its logic =
when
> > design changed and remain user side unchanged.
> > +
> > +config LS_RCPM
> > + bool "Freescale RCPM support"
> > + depends on (FSL_PLAT_PM)
> > + help
> > + This feature is to enable specified wakeup source for system sl=
eep.
> > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile
> > index 8f9db23..43ff71a 100644
> > --- a/drivers/soc/fsl/Makefile
> > +++ b/drivers/soc/fsl/Makefile
> > @@ -7,3 +7,4 @@ obj-$(CONFIG_QUICC_ENGINE) +=3D qe/
> > obj-$(CONFIG_CPM) +=3D qe/
> > obj-$(CONFIG_FSL_GUTS) +=3D guts.o
> > obj-$(CONFIG_FSL_PLAT_PM) +=3D plat_pm.o
> > +obj-$(CONFIG_LS_RCPM) +=3D ls-rcpm.o
Probably use "_" instead of "-" for alignment.
> > diff --git a/drivers/soc/fsl/ls-rcpm.c b/drivers/soc/fsl/ls-rcpm.c
> > new file mode 100644
> > index 0000000..b0feb88
> > --- /dev/null
> > +++ b/drivers/soc/fsl/ls-rcpm.c
> > @@ -0,0 +1,153 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +//
> > +// plat_pm.c - Freescale Layerscape RCPM driver
The file name here is not the same as the real file name.
> > +//
> > +// Copyright 2018 NXP
> > +//
> > +// Author: Ran Wang <ran.wang_1@nxp.com>,
Where do you need the comma in the end?
> > +
> > +#include <linux/init.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/of_address.h>
> > +#include <linux/slab.h>
> > +#include <soc/fsl/plat_pm.h>
> > +
> > +#define MAX_COMPATIBLE_NUM 10
> > +
> > +struct rcpm_t {
> > + struct device *dev;
> > + void __iomem *ippdexpcr_addr;
> > + bool big_endian; /* Big/Little endian of RCPM module */
> > +};
> > +
> > +// rcpm_handle - Configure RCPM reg according to wake up source reques=
t
> > +// @user_dev: pointer to user's device struct
> > +// @flag: to enable(true) or disable(false) wakeup source
> > +// @handle_priv: pointer to struct rcpm_t instance
> > +//
> > +// Return 0 on success other negative errno
Although Linus preferred this // comment style. I'm not sure if this
will be handled correctly by the kernel-doc compiler.
https://www.kernel.org/doc/html/v4.18/doc-guide/kernel-doc.html
> > +static int rcpm_handle(struct device *user_dev, bool flag, void *handl=
e_priv)
> > +{
> > + struct rcpm_t *rcpm;
> > + bool big_endian;
> > + const char *dev_compatible_array[MAX_COMPATIBLE_NUM];
> > + void __iomem *ippdexpcr_addr;
> > + u32 ippdexpcr;
> > + u32 set_bit;
> > + int ret, num, i;
> > +
> > + rcpm =3D handle_priv;
> > + big_endian =3D rcpm->big_endian;
> > + ippdexpcr_addr =3D rcpm->ippdexpcr_addr;
> > +
> > + num =3D device_property_read_string_array(user_dev, "compatible",
> > + dev_compatible_array, MAX_COMPATIBLE_NUM);
> > + if (num < 0)
> > + return num;
> > +
> > + for (i =3D 0; i < num; i++) {
> > + if (!device_property_present(rcpm->dev,
> > + dev_compatible_array[i]))
> > + continue;
> > + else {
> Remove this else.
> > + ret =3D device_property_read_u32(rcpm->dev,
> > + dev_compatible_array[i], &set_bit=
);
> > + if (ret)
> > + return ret;
> > +
> > + if (!device_property_present(rcpm->dev,
> > + dev_compatible_array[i]))
> This has been checked. Continue ? or return ENODEV=EF=BC=9F
> > + return -ENODEV;
> > + else {
> Remove this else.
> > + ret =3D device_property_read_u32(rcpm->de=
v,
> > + dev_compatible_array[i], =
&set_bit);
> > + if (ret)
> > + return ret;
> > +
> > + if (big_endian)
> > + ippdexpcr =3D ioread32be(ippdexpc=
r_addr);
> > + else
> > + ippdexpcr =3D ioread32(ippdexpcr_=
addr);
> > +
> > + if (flag)
> > + ippdexpcr |=3D set_bit;
> > + else
> > + ippdexpcr &=3D ~set_bit;
> > +
> > + if (big_endian) {
> > + iowrite32be(ippdexpcr, ippdexpcr_=
addr);
> > + ippdexpcr =3D ioread32be(ippdexpc=
r_addr);
> > + } else
> if (x) {
> ....
> ....
> } else {
>
> }
> > + iowrite32(ippdexpcr, ippdexpcr_ad=
dr);
> > +
> > + return 0;
> > + }
> > + }
> > + }
> > +
> > + return -ENODEV;
> > +}
> > +
> > +static int ls_rcpm_probe(struct platform_device *pdev)
> > +{
> > + struct resource *r;
> > + struct rcpm_t *rcpm;
> > +
> > + r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + if (!r)
> > + return -ENODEV;
> > +
> > + rcpm =3D kmalloc(sizeof(*rcpm), GFP_KERNEL);
> kzalloc is better.
> > + if (!rcpm)
> > + return -ENOMEM;
> > +
> > + rcpm->big_endian =3D device_property_read_bool(&pdev->dev, "big-e=
ndian");
> > +
> > + rcpm->ippdexpcr_addr =3D devm_ioremap_resource(&pdev->dev, r);
> > + if (IS_ERR(rcpm->ippdexpcr_addr))
> > + return PTR_ERR(rcpm->ippdexpcr_addr);
> > +
> > + rcpm->dev =3D &pdev->dev;
> > + platform_set_drvdata(pdev, rcpm);
> > +
> > + return register_fsl_platform_wakeup_source(rcpm_handle, rcpm);
> > +}
> > +
> > +static int ls_rcpm_remove(struct platform_device *pdev)
> > +{
> > + struct rcpm_t *rcpm;
> Not need a table.
>
> Cheers,
> -Dongsheng
>
> > +
> > + rcpm =3D platform_get_drvdata(pdev);
> > + deregister_fsl_platform_wakeup_source(rcpm);
> > + kfree(rcpm);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct of_device_id ls_rcpm_of_match[] =3D {
> > + { .compatible =3D "fsl,qoriq-rcpm-2.1", },
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(of, ls_rcpm_of_match);
> > +
> > +static struct platform_driver ls_rcpm_driver =3D {
> > + .driver =3D {
> > + .name =3D "ls-rcpm",
> > + .of_match_table =3D ls_rcpm_of_match,
> > + },
> > + .probe =3D ls_rcpm_probe,
> > + .remove =3D ls_rcpm_remove,
> > +};
> > +
> > +static int __init ls_rcpm_init(void)
> > +{
> > + return platform_driver_register(&ls_rcpm_driver);
> > +}
> > +subsys_initcall(ls_rcpm_init);
> > +
> > +static void __exit ls_rcpm_exit(void)
> > +{
> > + platform_driver_unregister(&ls_rcpm_driver);
> > +}
> > +module_exit(ls_rcpm_exit);
>
>
next prev parent reply other threads:[~2018-09-05 3:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 3:52 [PATCH 1/3] soc: fsl: add Platform PM driver QorIQ platforms Ran Wang
2018-08-31 3:52 ` [PATCH 2/3] Documentation: dt: binding: fsl: update property description for RCPM Ran Wang
2018-09-04 1:25 ` Rob Herring
2018-09-05 2:22 ` Ran Wang
2018-09-07 20:22 ` Scott Wood
2018-09-10 8:44 ` Ran Wang
2018-09-11 22:42 ` Li Yang
2018-08-31 3:52 ` [PATCH 3/3] soc: fsl: add RCPM driver Ran Wang
2018-09-05 2:57 ` Wang, Dongsheng
2018-09-05 3:21 ` Li Yang [this message]
2018-09-07 9:48 ` Ran Wang
2018-09-07 18:56 ` Li Yang
2018-09-10 3:31 ` Ran Wang
2018-09-07 9:32 ` Ran Wang
2018-09-07 20:25 ` Scott Wood
2018-09-10 9:09 ` Ran Wang
2018-09-05 3:04 ` [PATCH 1/3] soc: fsl: add Platform PM driver QorIQ platforms Wang, Dongsheng
2018-09-07 8:41 ` Ran Wang
2018-09-07 10:15 ` Wang, Dongsheng
2018-09-10 3:27 ` Ran Wang
2018-09-07 20:35 ` Scott Wood
2018-09-10 9:26 ` Ran Wang
2019-05-17 2:47 [PATCH 1/3] PM: wakeup: Add routine to help fetch wakeup source object Ran Wang
2019-05-17 2:47 ` [PATCH 3/3] soc: fsl: add RCPM driver Ran Wang
2019-10-22 7:51 [PATCH 1/3] PM: wakeup: Add routine to help fetch wakeup source object Ran Wang
2019-10-22 7:51 ` [PATCH 3/3] soc: fsl: add RCPM driver Ran Wang
2019-10-22 9:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADRPPNQN=27+pOSckxvwSuBJoFaz7pT+Z6h07Wu3Liz5ao5kkA@mail.gmail.com' \
--to=leoyang.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=ran.wang_1@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).