From: Scott Wood <oss@buserror.net>
To: Ran Wang <ran.wang_1@nxp.com>, Leo Li <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] Documentation: dt: binding: fsl: update property description for RCPM
Date: Fri, 07 Sep 2018 15:22:48 -0500 [thread overview]
Message-ID: <c19f11e200258297dbe5a61392a4bbc1e937d7c3.camel@buserror.net> (raw)
In-Reply-To: <20180831035219.31619-2-ran.wang_1@nxp.com>
On Fri, 2018-08-31 at 11:52 +0800, Ran Wang wrote:
> +Optional properties:
> + - big-endian : Indicate RCPM registers is big-endian. A RCPM node
> + that doesn't have this property will be regarded as little-endian.
You've just broken all the existing powerpc device trees that are big-endian
and have no big-endian property.
> + - <property 'compatible' string of consumer device> : This string
> + is referred by RCPM driver to judge if the consumer (such as flex timer)
> + is able to be regards as wakeup source or not, such as 'fsl,ls1012a-
> ftm'.
> + Further, this property will carry the bit mask info to control
> + coresponding wake up source.
What will you do if there are multiple instances of a device with the same
compatible, and different wakeup bits? Plus, it's an awkward design in
general, and you don't describe what the value actually means (bits in which
register?). What was wrong with the existing binding? Alternatively, use the
clock bindings.
> -
> -Example:
> - lpuart0: serial@2950000 {
> - compatible = "fsl,ls1021a-lpuart";
> - reg = <0x0 0x2950000 0x0 0x1000>;
> - interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&sysclk>;
> - clock-names = "ipg";
> - fsl,rcpm-wakeup = <&rcpm 0x0 0x40000000>;
> + big-endian;
> + fsl,ls1012a-ftm = <0x20000>;
> + fsl,pfe = <0xf0000020>;
fsl,pfe is not documented.
-Scott
next prev parent reply other threads:[~2018-09-07 20:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 3:52 [PATCH 1/3] soc: fsl: add Platform PM driver QorIQ platforms Ran Wang
2018-08-31 3:52 ` [PATCH 2/3] Documentation: dt: binding: fsl: update property description for RCPM Ran Wang
2018-09-04 1:25 ` Rob Herring
2018-09-05 2:22 ` Ran Wang
2018-09-07 20:22 ` Scott Wood [this message]
2018-09-10 8:44 ` Ran Wang
2018-09-11 22:42 ` Li Yang
2018-08-31 3:52 ` [PATCH 3/3] soc: fsl: add RCPM driver Ran Wang
2018-09-05 2:57 ` Wang, Dongsheng
2018-09-05 3:21 ` Li Yang
2018-09-07 9:48 ` Ran Wang
2018-09-07 18:56 ` Li Yang
2018-09-10 3:31 ` Ran Wang
2018-09-07 9:32 ` Ran Wang
2018-09-07 20:25 ` Scott Wood
2018-09-10 9:09 ` Ran Wang
2018-09-05 3:04 ` [PATCH 1/3] soc: fsl: add Platform PM driver QorIQ platforms Wang, Dongsheng
2018-09-07 8:41 ` Ran Wang
2018-09-07 10:15 ` Wang, Dongsheng
2018-09-10 3:27 ` Ran Wang
2018-09-07 20:35 ` Scott Wood
2018-09-10 9:26 ` Ran Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19f11e200258297dbe5a61392a4bbc1e937d7c3.camel@buserror.net \
--to=oss@buserror.net \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=ran.wang_1@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).