linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RFC] possible null dereference in 'pm121_create_sys_fans()'
@ 2013-11-17 19:10 Geyslan Gregório Bem
  0 siblings, 0 replies; only message in thread
From: Geyslan Gregório Bem @ 2013-11-17 19:10 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, LKML

Hello Benjamin,

In file 'windfarm_pm121'.c:

If this branch is true:

    if (param == NULL) {
        printk(KERN_WARNING "pm121: %s fan config not found "
               " for this machine model\n",
               loop_names[loop_id]);
        goto fail;
    }

control that is NULL will suffer a dereference attempt:

fail:
    /* note that this is not optimal since another loop may still
       control the same control */
    printk(KERN_WARNING "pm121: failed to set up %s loop "
           "setting \"%s\" to max speed.\n",
           loop_names[loop_id], control->name);


Reported-by: Geyslan G. Bem <geyslan@gmail.com>

-- 
Regards,

Geyslan G. Bem
hackingbits.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-11-17 19:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-17 19:10 [RFC] possible null dereference in 'pm121_create_sys_fans()' Geyslan Gregório Bem

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).