From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vaibhav Jain <vaibhav@linux.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API
Date: Thu, 15 Apr 2021 20:18:49 +0300 [thread overview]
Message-ID: <CAHp75VcPANL+LBTxy2V8f2Ksy=FJmdbU1=r60KKO7YSUf9BCLg@mail.gmail.com> (raw)
In-Reply-To: <87eefblbji.fsf@vajain21.in.ibm.com>
On Thu, Apr 15, 2021 at 8:10 PM Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>
>
> Thanks for the patch Andy,
>
> Unfortunately ran into a compilation issue due to missing "#include
> <asm/unaligned.h>" that provides definition for
> get_unaligned_le64(). Gcc reported following error:
>
> error: implicit declaration of function ‘get_unaligned_le64’
Right, I have not tested it (as mentioned in the comments to the patch)
> After including the necessary header file, kernel compiled fine and I
> was able to test & verify the patch.
Thank you very much for the testing.
I'm not sure what the coverage of your test is. That's why I have an
additional question below. Is the byte ordering kept the same in BE
(32- and 64-bit) cases? Because I'm worrying that I might have missed
something.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-15 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:46 [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API Andy Shevchenko
2021-04-15 17:09 ` Vaibhav Jain
2021-04-15 17:18 ` Andy Shevchenko [this message]
2021-04-16 15:06 ` Vaibhav Jain
2021-04-16 4:38 ` Aneesh Kumar K.V
2021-04-16 7:58 ` Aneesh Kumar K.V
2021-04-16 9:09 ` Andy Shevchenko
2021-04-16 9:35 ` Aneesh Kumar K.V
2021-06-16 13:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcPANL+LBTxy2V8f2Ksy=FJmdbU1=r60KKO7YSUf9BCLg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).