* [PATCH] mv643xx_eth: fix return value check in mv64x60_eth_register_shared_pdev()
@ 2013-10-25 9:30 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2013-10-25 9:30 UTC (permalink / raw)
To: benh, paulus, grant.likely, rob.herring, davem, florian
Cc: yongjun_wei, linuxppc-dev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function platform_device_register_simple() returns
RR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/powerpc/sysdev/mv64x60_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/mv64x60_dev.c b/arch/powerpc/sysdev/mv64x60_dev.c
index 4a25c26..a3a8fad 100644
--- a/arch/powerpc/sysdev/mv64x60_dev.c
+++ b/arch/powerpc/sysdev/mv64x60_dev.c
@@ -228,7 +228,7 @@ static struct platform_device * __init mv64x60_eth_register_shared_pdev(
if (id == 0) {
pdev = platform_device_register_simple("orion-mdio", -1, &r[1], 1);
- if (!pdev)
+ if (IS_ERR(pdev))
return pdev;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-10-25 9:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-25 9:30 [PATCH] mv643xx_eth: fix return value check in mv64x60_eth_register_shared_pdev() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).