Re: [PATCH 1/3] powerpc/mpic: add irq_set_wake support

[Gala Kumar-B11780 <B11780@freescale.com>]

On Mar 18, 2013, at 9:41 AM, Benjamin Herrenschmidt wrote:

> On Mon, 2013-03-18 at 09:28 +0000, Wang Dongsheng-B40534 wrote:
>> Hi Benjamin & Kumar,
>>=20
>> I am not sure who can apply these patches...
>>=20
>> Could you apply these patches?
>=20
> I can but I need somebody to review them, I don't have the bandwidth nor
> am I familiar with the FSL changes to the MPIC.
>=20
> Cheers,
> Ben.

I'd ask for Scott's ack/signoff on these patches for ben or I to accept the=
m.

- k

>=20
>> Thanks.
>>=20
>> [1/3] powerpc/mpic: add irq_set_wake support
>> http://patchwork.ozlabs.org/patch/226034/
>>=20
>> [2/3] powerpc/mpic: add global timer support
>> http://patchwork.ozlabs.org/patch/226035/
>>=20
>> [3/3] powerpc/fsl: add MPIC timer wakeup support
>> http://patchwork.ozlabs.org/patch/226036/
>>=20
>>> -----Original Message-----
>>> From: Wang Dongsheng-B40534
>>> Sent: Friday, March 08, 2013 3:39 PM
>>> To: Wood Scott-B07421; Gala Kumar-B11780
>>> Cc: linuxppc-dev@lists.ozlabs.org; Wang Dongsheng-B40534
>>> Subject: [PATCH 1/3] powerpc/mpic: add irq_set_wake support
>>>=20
>>> Add irq_set_wake support. Just add IRQF_NO_SUSPEND to desc->action->fla=
g.
>>> So the wake up interrupt will not be disable in suspend_device_irqs.
>>>=20
>>> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
>>> ---
>>> arch/powerpc/sysdev/mpic.c |   15 +++++++++++++++
>>> 1 files changed, 15 insertions(+), 0 deletions(-)
>>>=20
>>> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
>>> index 3b2efd4..10e474e 100644
>>> --- a/arch/powerpc/sysdev/mpic.c
>>> +++ b/arch/powerpc/sysdev/mpic.c
>>> @@ -920,6 +920,18 @@ int mpic_set_irq_type(struct irq_data *d, unsigned
>>> int flow_type)
>>> 	return IRQ_SET_MASK_OK_NOCOPY;
>>> }
>>>=20
>>> +static int mpic_irq_set_wake(struct irq_data *d, unsigned int on) {
>>> +	struct irq_desc *desc =3D container_of(d, struct irq_desc, irq_data);
>>> +
>>> +	if (on)
>>> +		desc->action->flags |=3D IRQF_NO_SUSPEND;
>>> +	else
>>> +		desc->action->flags &=3D ~IRQF_NO_SUSPEND;
>>> +
>>> +	return 0;
>>> +}
>>> +
>>> void mpic_set_vector(unsigned int virq, unsigned int vector)  {
>>> 	struct mpic *mpic =3D mpic_from_irq(virq); @@ -957,6 +969,7 @@ static
>>> struct irq_chip mpic_irq_chip =3D {
>>> 	.irq_unmask	=3D mpic_unmask_irq,
>>> 	.irq_eoi	=3D mpic_end_irq,
>>> 	.irq_set_type	=3D mpic_set_irq_type,
>>> +	.irq_set_wake	=3D mpic_irq_set_wake,
>>> };
>>>=20
>>> #ifdef CONFIG_SMP
>>> @@ -971,6 +984,7 @@ static struct irq_chip mpic_tm_chip =3D {
>>> 	.irq_mask	=3D mpic_mask_tm,
>>> 	.irq_unmask	=3D mpic_unmask_tm,
>>> 	.irq_eoi	=3D mpic_end_irq,
>>> +	.irq_set_wake	=3D mpic_irq_set_wake,
>>> };
>>>=20
>>> #ifdef CONFIG_MPIC_U3_HT_IRQS
>>> @@ -981,6 +995,7 @@ static struct irq_chip mpic_irq_ht_chip =3D {
>>> 	.irq_unmask	=3D mpic_unmask_ht_irq,
>>> 	.irq_eoi	=3D mpic_end_ht_irq,
>>> 	.irq_set_type	=3D mpic_set_irq_type,
>>> +	.irq_set_wake	=3D mpic_irq_set_wake,
>>> };
>>> #endif /* CONFIG_MPIC_U3_HT_IRQS */
>>>=20
>>> --
>>> 1.7.5.1
>>=20
>=20
>=20
>=20