From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0
Date: Thu, 10 Nov 2022 15:33:28 +0100 [thread overview]
Message-ID: <Y20LuAqHljYI4Bo8@kroah.com> (raw)
In-Reply-To: <bccb8729-7f0a-5f97-d1b1-5401ed9f3235@csgroup.eu>
On Thu, Nov 10, 2022 at 01:25:14PM +0000, Christophe Leroy wrote:
> Hi Greg,
>
> Le 06/10/2022 à 07:27, Christophe Leroy a écrit :
> > NO_IRQ is used to check the return of irq_of_parse_and_map().
> >
> > On some architecture NO_IRQ is 0, on other architectures it is -1.
> >
> > irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> >
> > So use 0 instead of using NO_IRQ.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Do you plan to apply this patch, or is any change required ?
It is in my review queue, give me time to catch up...
thanks,
greg k-h
prev parent reply other threads:[~2022-11-10 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:27 [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0 Christophe Leroy
2022-11-10 13:25 ` Christophe Leroy
2022-11-10 14:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20LuAqHljYI4Bo8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).