From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0
Date: Thu, 10 Nov 2022 13:25:14 +0000 [thread overview]
Message-ID: <bccb8729-7f0a-5f97-d1b1-5401ed9f3235@csgroup.eu> (raw)
In-Reply-To: <20dd37b96bac0a72caef28e7462b32c93487a516.1665033909.git.christophe.leroy@csgroup.eu>
Hi Greg,
Le 06/10/2022 à 07:27, Christophe Leroy a écrit :
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Do you plan to apply this patch, or is any change required ?
Thanks
Christophe
> ---
> drivers/virt/fsl_hypervisor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
> index 07035249a5e1..f8b4389d60d9 100644
> --- a/drivers/virt/fsl_hypervisor.c
> +++ b/drivers/virt/fsl_hypervisor.c
> @@ -839,7 +839,7 @@ static int __init fsl_hypervisor_init(void)
>
> handle = of_get_property(np, "interrupts", NULL);
> irq = irq_of_parse_and_map(np, 0);
> - if (!handle || (irq == NO_IRQ)) {
> + if (!handle || !irq) {
> pr_err("fsl-hv: no 'interrupts' property in %pOF node\n",
> np);
> continue;
next prev parent reply other threads:[~2022-11-10 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:27 [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0 Christophe Leroy
2022-11-10 13:25 ` Christophe Leroy [this message]
2022-11-10 14:33 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bccb8729-7f0a-5f97-d1b1-5401ed9f3235@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).