From: Wolfram Sang <wsa@kernel.org>
To: Sven Peter <sven@svenpeter.dev>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Hector Martin <marcan@marcan.st>,
Nicholas Piggin <npiggin@gmail.com>,
linux-kernel@vger.kernel.org,
Arminder Singh <arminders208@outlook.com>,
linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev
Subject: Re: [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement
Date: Tue, 1 Nov 2022 13:53:18 +0100 [thread overview]
Message-ID: <Y2EWvokvkixLucg+@shikoro> (raw)
In-Reply-To: <A0B81E7F-BF26-424D-B9E5-5647323B24EC@svenpeter.dev>
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
> > + complete(&smbus->irq_completion);
>
> I only realized just now that you also want to disable the interrupt
> right here by writing to IMASK. This is a level sensitive interrupt at
> AIC level so the moment this handler returns it will fire again until
> you reach the write above after the completion wait a bit later.
This seems like a valid request. Any chance for a v4? We are so close to
being good here...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-01 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 0:42 [PATCH v3] i2c/pasemi: PASemi I2C controller IRQ enablement Arminder Singh
2022-10-08 9:48 ` Sven Peter
2022-11-01 12:53 ` Wolfram Sang [this message]
2022-11-01 20:02 ` Arminder Singh
2022-11-01 18:28 ` Hector Martin
2022-11-01 20:06 ` Arminder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2EWvokvkixLucg+@shikoro \
--to=wsa@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=arminders208@outlook.com \
--cc=asahi@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=npiggin@gmail.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).