From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Darrick J . Wong" <djwong@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
dri-devel@lists.freedesktop.org,
"Andrii Nakryiko" <andrii@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
linux-sctp@vger.kernel.org,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Rohit Maheshwari" <rohitm@chelsio.com>,
ceph-devel@vger.kernel.org,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"Nilesh Javali" <njavali@marvell.com>,
"Jean-Paul Roubelat" <jpr@f6fbb.org>,
"Dick Kennedy" <dick.kennedy@broadcom.com>,
"Jay Vosburgh" <j.vosburgh@gmail.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
"Vinay Kumar Yadav" <vinay.yadav@chelsio.com>,
linux-nfs@vger.kernel.org, "Nicholas Piggin" <npiggin@gmail.com>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Andy Lutomirski" <luto@kernel.org>,
linux-hams@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
linux-raid@vger.kernel.org, "Neil Horman" <nhorman@tuxdriver.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Michael Chan" <michael.chan@broadcom.com>,
linux-kernel@vger.kernel.org, "Varun Prakash" <varun@chelsio.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
netfilter-devel@vger.kernel.org,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Jiri Olsa" <jolsa@kernel.org>, "Jan Kara" <jack@suse.com>,
linux-fsdevel@vger.kernel.org,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
linux-media@vger.kernel.org,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Sharvari Harisangam" <sharvari.harisangam@nxp.com>,
linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mmc@vger.kernel.org,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Song Liu" <song@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
target-devel@vger.kernel.org, "John Stultz" <jstultz@google.com>,
"Stanislav Fomichev" <sdf@googl>
Subject: Re: [PATCH v1 1/5] treewide: use prandom_u32_max() when possible
Date: Thu, 6 Oct 2022 09:55:19 -0300 [thread overview]
Message-ID: <Yz7QN3cbKABexzoB@ziepe.ca> (raw)
In-Reply-To: <Yz7N5WsqmKiUl+6b@zx2c4.com>
On Thu, Oct 06, 2022 at 06:45:25AM -0600, Jason A. Donenfeld wrote:
> Hi Kees,
>
> On Wed, Oct 05, 2022 at 09:16:50PM -0700, Kees Cook wrote:
> > On Wed, Oct 05, 2022 at 11:48:40PM +0200, Jason A. Donenfeld wrote:
> > > Rather than incurring a division or requesting too many random bytes for
> > > the given range, use the prandom_u32_max() function, which only takes
> > > the minimum required bytes from the RNG and avoids divisions.
> >
> > Yes please!
> >
> > Since this is a treewide patch, it's helpful for (me at least) doing
> > reviews to detail the mechanism of the transformation.
>
> This is hand done. There were also various wrong seds done. And then I'd
> edit the .diff manually, and then reapply it, as an iterative process.
> No internet on the airplane, and oddly no spatch already on my laptop (I
> think I had some Gentoo ocaml issues at some point and removed it?).
>
> > e.g. I imagine this could be done with something like Coccinelle and
>
> Feel free to check the work here by using Coccinelle if you're into
> that.
Generally these series are a lot easier to review if it is structured
as a patches doing all the unusual stuff that had to be by hand
followed by an unmodified Coccinelle/sed/etc handling the simple
stuff.
Especially stuff that is reworking the logic beyond simple
substitution should be one patch per subsystem not rolled into a giant
one patch conversion.
This makes the whole workflow better because the hand-done stuff can
have a chance to flow through subsystem trees.
Thanks,
Jason
next prev parent reply other threads:[~2022-10-06 22:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 21:48 [PATCH v1 0/5] treewide cleanup of random integer usage Jason A. Donenfeld
2022-10-05 21:48 ` [PATCH v1 1/5] treewide: use prandom_u32_max() when possible Jason A. Donenfeld
2022-10-06 4:16 ` Kees Cook
2022-10-06 4:22 ` KP Singh
2022-10-06 12:45 ` Jason A. Donenfeld
2022-10-06 12:55 ` Jason Gunthorpe [this message]
2022-10-06 13:05 ` Andy Shevchenko
2022-10-05 21:48 ` [PATCH v1 2/5] treewide: use get_random_{u8,u16}() " Jason A. Donenfeld
2022-10-06 4:38 ` Kees Cook
2022-10-06 12:28 ` Jason A. Donenfeld
2022-10-05 21:48 ` [PATCH v1 3/5] treewide: use get_random_u32() " Jason A. Donenfeld
2022-10-06 8:43 ` Jan Kara
2022-10-06 12:33 ` [f2fs-dev] " Jason A. Donenfeld
2022-10-06 13:01 ` Andy Shevchenko
2022-10-06 13:07 ` Jason A. Donenfeld
2022-10-06 12:47 ` Jason Gunthorpe
2022-10-06 13:05 ` Jason A. Donenfeld
2022-10-06 13:15 ` Jason Gunthorpe
2022-10-06 13:20 ` Andy Shevchenko
2022-10-12 19:16 ` Joe Perches
2022-10-12 21:29 ` David Laight
2022-10-13 1:37 ` Joe Perches
2022-10-05 21:48 ` [PATCH v1 4/5] treewide: use get_random_bytes " Jason A. Donenfeld
2022-10-06 4:45 ` Kees Cook
2022-10-06 4:48 ` Kees Cook
2022-10-05 21:48 ` [PATCH v1 5/5] prandom: remove unused functions Jason A. Donenfeld
2022-10-06 4:39 ` Kees Cook
2022-10-06 4:55 ` [PATCH v1 0/5] treewide cleanup of random integer usage Kees Cook
2022-10-06 5:40 ` Kees Cook
2022-10-06 12:53 ` Jason A. Donenfeld
2022-10-06 13:49 ` [f2fs-dev] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz7QN3cbKABexzoB@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Jason@zx2c4.com \
--cc=andrew@lunn.ch \
--cc=andrii@kernel.org \
--cc=andy@greyhouse.net \
--cc=bharat@chelsio.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=claudiu.beznea@microchip.com \
--cc=dave.hansen@linux.intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=geomatsi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hante.meuleman@broadcom.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=hverkuil@xs4all.nl \
--cc=imitsyanko@quantenna.com \
--cc=j.vosburgh@gmail.com \
--cc=jack@suse.com \
--cc=jolsa@kernel.org \
--cc=jpr@f6fbb.org \
--cc=jstultz@google.com \
--cc=kadlec@netfilter.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=miquel.raynal@bootlin.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=njavali@marvell.com \
--cc=npiggin@gmail.com \
--cc=rohitm@chelsio.com \
--cc=sdf@googl \
--cc=sharvari.harisangam@nxp.com \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=trond.myklebust@hammerspace.com \
--cc=ulf.hansson@linaro.org \
--cc=varun@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).