From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-block@vger.kernel.org,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
dri-devel@lists.freedesktop.org,
"Andrii Nakryiko" <andrii@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
linux-sctp@vger.kernel.org,
"Md . Haris Iqbal" <haris.iqbal@ionos.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Rohit Maheshwari" <rohitm@chelsio.com>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"Nilesh Javali" <njavali@marvell.com>,
"Jean-Paul Roubelat" <jpr@f6fbb.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dick Kennedy" <dick.kennedy@broadcom.com>,
"Jay Vosburgh" <j.vosburgh@gmail.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
"Vinay Kumar Yadav" <vinay.yadav@chelsio.com>,
"Arend van Spriel" <aspriel@gmail.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Andy Lutomirski" <luto@kernel.org>,
linux-hams@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Michael Chan" <michael.chan@broadcom.com>,
linux-kernel@vger.kernel.org, "Varun Prakash" <varun@chelsio.com>,
"David Ahern" <dsahern@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org,
"Jiri Olsa" <jolsa@kernel.org>, "Jan Kara" <jack@suse.com>,
linux-fsdevel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Sharvari Harisangam" <sharvari.harisangam@nxp.com>,
linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-wireless@vger.kernel.org,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Song Liu" <song@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
target-devel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v1 3/5] treewide: use get_random_u32() when possible
Date: Thu, 6 Oct 2022 16:01:11 +0300 [thread overview]
Message-ID: <Yz7Rl7BXamKQhRzH@smile.fi.intel.com> (raw)
In-Reply-To: <Yz7LCyIAHC6l5mG9@zx2c4.com>
On Thu, Oct 06, 2022 at 06:33:15AM -0600, Jason A. Donenfeld wrote:
> On Thu, Oct 06, 2022 at 10:43:31AM +0200, Jan Kara wrote:
...
> > The code here is effectively doing the
> >
> > parent_group = prandom_u32_max(ngroups);
> >
> > Similarly here we can use prandom_u32_max(ngroups) like:
> >
> > if (qstr) {
> > ...
> > parent_group = hinfo.hash % ngroups;
> > } else
> > parent_group = prandom_u32_max(ngroups);
>
> Nice catch. I'll move these to patch #1.
I believe coccinelle is able to handle this kind of code as well, so Kees'
proposal to use it seems more plausible since it's less error prone and more
flexible / powerful.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-06 22:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 21:48 [PATCH v1 0/5] treewide cleanup of random integer usage Jason A. Donenfeld
2022-10-05 21:48 ` [PATCH v1 1/5] treewide: use prandom_u32_max() when possible Jason A. Donenfeld
2022-10-06 4:16 ` Kees Cook
2022-10-06 4:22 ` KP Singh
2022-10-06 12:45 ` Jason A. Donenfeld
2022-10-06 12:55 ` Jason Gunthorpe
2022-10-06 13:05 ` Andy Shevchenko
2022-10-05 21:48 ` [PATCH v1 2/5] treewide: use get_random_{u8,u16}() " Jason A. Donenfeld
2022-10-06 4:38 ` Kees Cook
2022-10-06 12:28 ` Jason A. Donenfeld
2022-10-05 21:48 ` [PATCH v1 3/5] treewide: use get_random_u32() " Jason A. Donenfeld
2022-10-06 8:43 ` Jan Kara
2022-10-06 12:33 ` [f2fs-dev] " Jason A. Donenfeld
2022-10-06 13:01 ` Andy Shevchenko [this message]
2022-10-06 13:07 ` Jason A. Donenfeld
2022-10-06 12:47 ` Jason Gunthorpe
2022-10-06 13:05 ` Jason A. Donenfeld
2022-10-06 13:15 ` Jason Gunthorpe
2022-10-06 13:20 ` Andy Shevchenko
2022-10-12 19:16 ` Joe Perches
2022-10-12 21:29 ` David Laight
2022-10-13 1:37 ` Joe Perches
2022-10-05 21:48 ` [PATCH v1 4/5] treewide: use get_random_bytes " Jason A. Donenfeld
2022-10-06 4:45 ` Kees Cook
2022-10-06 4:48 ` Kees Cook
2022-10-05 21:48 ` [PATCH v1 5/5] prandom: remove unused functions Jason A. Donenfeld
2022-10-06 4:39 ` Kees Cook
2022-10-06 4:55 ` [PATCH v1 0/5] treewide cleanup of random integer usage Kees Cook
2022-10-06 5:40 ` Kees Cook
2022-10-06 12:53 ` Jason A. Donenfeld
2022-10-06 13:49 ` [f2fs-dev] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz7Rl7BXamKQhRzH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=andrii@kernel.org \
--cc=andy@greyhouse.net \
--cc=aspriel@gmail.com \
--cc=bharat@chelsio.com \
--cc=chuck.lever@oracle.com \
--cc=claudiu.beznea@microchip.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geomatsi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=hverkuil@xs4all.nl \
--cc=imitsyanko@quantenna.com \
--cc=j.vosburgh@gmail.com \
--cc=jack@suse.com \
--cc=jolsa@kernel.org \
--cc=jpr@f6fbb.org \
--cc=kadlec@netfilter.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=michael.chan@broadcom.com \
--cc=miquel.raynal@bootlin.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=npiggin@gmail.com \
--cc=rohitm@chelsio.com \
--cc=sharvari.harisangam@nxp.com \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=trond.myklebust@hammerspace.com \
--cc=varun@chelsio.com \
--cc=vigneshr@ti.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).