linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Geoff Levand <geoff@infradead.org>, linuxppc-dev@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jens Axboe <axboe@kernel.dk>, Jim Paris <jim@jtan.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
Date: Tue, 8 Aug 2017 10:23:50 +0200	[thread overview]
Message-ID: <a4b69182-80d3-c5e6-ab7a-6da2b99e5ddc@users.sourceforge.net> (raw)
In-Reply-To: <db00e381-a79e-4db2-2263-458b80e4844c@infradead.org>

>> https://patchwork.ozlabs.org/patch/798575/
> 
> I submitted your patch

Thanks for your constructive feedback.
https://patchwork.ozlabs.org/patch/798850/


> and a fix to ps3vram_probe() with the other patches in my queue.

I find it nice that you picked this change opportunity up after
a bit of discussion (before an other developer would eventually
have tackled it also).

“Check return of ps3vram_cache_init”
https://patchwork.ozlabs.org/patch/798853/

1. Unfortunately, I find that this specific update suggestion does not fit
   to the Linux coding style convention.

   “…
   Do not unnecessarily use braces where a single statement will do.
   …”

2. How do you think about to use the check “if (error)” instead?

3. Will an additional commit description be useful?

Regards,
Markus

  reply	other threads:[~2017-08-08  8:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 10:52 [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() SF Markus Elfring
2017-08-07 15:10 ` Geoff Levand
2017-08-07 15:13   ` Joe Perches
2017-08-07 16:27   ` SF Markus Elfring
2017-08-07 18:28     ` Geoff Levand
2017-08-07 18:34       ` SF Markus Elfring
2017-08-07 18:49         ` Geoff Levand
2017-08-07 19:04           ` SF Markus Elfring
2017-08-07 20:17             ` Geoff Levand
2017-08-08  8:23               ` SF Markus Elfring [this message]
2017-08-08  2:13             ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4b69182-80d3-c5e6-ab7a-6da2b99e5ddc@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=geoff@infradead.org \
    --cc=jim@jtan.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).