From: Geoff Levand <geoff@infradead.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linuxppc-dev@lists.ozlabs.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
Date: Mon, 7 Aug 2017 08:10:59 -0700 [thread overview]
Message-ID: <b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org> (raw)
In-Reply-To: <e22ee16a-5f34-46bd-577f-9b7ca75e9035@users.sourceforge.net>
On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 7 Aug 2017 12:37:01 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
NACK
When a user asks me for help I would certainly like to get
'Could not allocate cache tags' as apposed to nothing, since
the return value of ps3vram_cache_init() is not checked.
If you want to make an improvement please add a check for
success of ps3vram_cache_init() in ps3vram_probe().
-Geoff
next prev parent reply other threads:[~2017-08-07 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 10:52 [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() SF Markus Elfring
2017-08-07 15:10 ` Geoff Levand [this message]
2017-08-07 15:13 ` Joe Perches
2017-08-07 16:27 ` SF Markus Elfring
2017-08-07 18:28 ` Geoff Levand
2017-08-07 18:34 ` SF Markus Elfring
2017-08-07 18:49 ` Geoff Levand
2017-08-07 19:04 ` SF Markus Elfring
2017-08-07 20:17 ` Geoff Levand
2017-08-08 8:23 ` SF Markus Elfring
2017-08-08 2:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org \
--to=geoff@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).