From: Sinan Kaya <okaya@kernel.org>
To: Keith Busch <keith.busch@intel.com>,
Tyler Baicar <baicar.tyler@gmail.com>
Cc: alex_gagniuc@dellteam.com, helgaas@google.com,
sbobroff@linux.ibm.com, linux-pci@vger.kernel.org,
Shyam_Iyer@dell.com, rjw@rjwysocki.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, lukas@wunner.de, oohall@gmail.com,
mr.nuke.me@gmail.com, bhelgaas@google.com, austin_bolen@dell.com,
linuxppc-dev@lists.ozlabs.org, lenb@kernel.org
Subject: Re: [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER
Date: Mon, 19 Nov 2018 12:42:25 -0500 [thread overview]
Message-ID: <ab2427f1-c1f0-68fe-5335-1494caafdcbb@kernel.org> (raw)
In-Reply-To: <74f2c527-0890-5e14-5e2d-48934a42dae6@kernel.org>
On 11/19/2018 12:32 PM, Sinan Kaya wrote:
>>
>> But we're not using HEST as a fine grain control. We disable native AER
>> handling if *any* device has FF set in HEST, and that just forces people
>> to use pcie_ports=native to get around that.
>>
>
> I don't see *any* in the code. aer_hest_parse() does the HEST table parsing.
> It switches to firmware first mode if global flag in HEST is set. Otherwise
> for each BDF in device, hest_match_pci() is used to do a cross-matching against
> HEST table contents.
>
> Am I missing something?
I see. I think you are talking about aer_firmware_first, right?
aer_set_firmware_first() and pcie_aer_get_firmware_first() seem to do the right
thing.
aer_firmware_first is probably getting set because events are all routed to a
single root port and aer_acpi_firmware_first() is used to decide whether AER
should be initialized or not.
I think I understand what is going on now.
Still, breaking existing systems that rely on HEST table is not cool.
I'd rather have users specify "pcie_ports=native" to skip FF rather than
having broken systems by default to be honest.
next prev parent reply other threads:[~2018-11-19 17:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 23:16 [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER Alexandru Gagniuc
2018-11-15 23:16 ` [PATCH 1/2] PCI/AER: Do not use APEI/HEST to disable AER services globally Alexandru Gagniuc
2018-11-15 23:16 ` [PATCH 2/2] PCI/AER: Determine AER ownership based on _OSC instead of HEST Alexandru Gagniuc
2018-11-15 23:43 ` Keith Busch
2018-11-16 1:49 ` [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER Sinan Kaya
2018-11-19 16:53 ` Tyler Baicar
2018-11-19 16:53 ` Keith Busch
2018-11-19 17:32 ` Sinan Kaya
2018-11-19 17:36 ` Keith Busch
2018-11-19 17:42 ` Sinan Kaya [this message]
2018-11-19 17:41 ` Keith Busch
2018-11-19 17:56 ` Sinan Kaya
2018-11-19 18:10 ` Keith Busch
2018-11-19 18:24 ` Sinan Kaya
2018-11-19 19:11 ` Alex G.
2018-11-19 19:32 ` Sinan Kaya
2018-11-19 20:16 ` Alex_Gagniuc
2018-11-19 20:33 ` Sinan Kaya
2018-11-19 23:49 ` Alex_Gagniuc
2018-11-20 1:54 ` Sinan Kaya
2018-11-20 20:44 ` Alex_Gagniuc
2018-11-20 21:02 ` Sinan Kaya
2018-11-20 21:42 ` Keith Busch
2018-11-20 22:28 ` Sinan Kaya
2018-11-20 22:35 ` Alex G.
2018-11-20 21:46 ` Alex_Gagniuc
2018-11-20 22:08 ` Sinan Kaya
2018-11-20 22:36 ` Alex_Gagniuc
2018-11-27 18:22 ` Alex_Gagniuc
2018-11-27 18:32 ` Sinan Kaya
2018-11-27 18:46 ` Tyler Baicar
2018-11-16 12:37 ` David Laight
2019-03-05 23:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2427f1-c1f0-68fe-5335-1494caafdcbb@kernel.org \
--to=okaya@kernel.org \
--cc=Shyam_Iyer@dell.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=baicar.tyler@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@google.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=oohall@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).