drivers/video/logo/logo_linux_mono.c build error

drivers/video/logo/logo_linux_mono.c build error

[Andrew Morton]

powerpc allmodconfig, current mainline:

drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict

switching it from __initconst to __initdata "fixes" it.

I'm (illegally) using gcc-4.1.0.

I assume this is an FAQ but I don't know what the A is ;)

Re: drivers/video/logo/logo_linux_mono.c build error

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi Andrew,

On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> powerpc allmodconfig, current mainline:
> 
> drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> 
> switching it from __initconst to __initdata "fixes" it.

Interesting.  The program that generates the .c file above produces
__initdata for me ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: drivers/video/logo/logo_linux_mono.c build error

[Geert Uytterhoeven]

On Tue, 28 Apr 2009, Stephen Rothwell wrote:
> On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > powerpc allmodconfig, current mainline:
> > 
> > drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> > 
> > switching it from __initconst to __initdata "fixes" it.
> 
> Interesting.  The program that generates the .c file above produces
> __initdata for me ...

I assume Andrew once built in that tree using the recent logo patches that
  1. Makes the logos const and switch them from __initdata to __initconst,
  2. Fix the missing dependency of the generated files on the generator program.
Hence if you revert the logo patches, you have to manually remove the generated
files.

Is my assumption correct?

With kind regards,

Geert Uytterhoeven
Software Architect
Techsoft Centre

Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

Re: drivers/video/logo/logo_linux_mono.c build error

[Tony Breeds]

On Mon, Apr 27, 2009 at 02:50:31PM -0700, Andrew Morton wrote:
> 
> powerpc allmodconfig, current mainline:
> 
> drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> 
> switching it from __initconst to __initdata "fixes" it.
> 
> I'm (illegally) using gcc-4.1.0.

You could use the compilers at:
	http://bakeyournoodle.com/cross/

Currently x86_64 hosted only, but i686  hosted compilers are building now :)
 
Yours Tony

Re: drivers/video/logo/logo_linux_mono.c build error

[Andrew Morton]

On Tue, 28 Apr 2009 09:24:53 +0200 (CEST)
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:

> On Tue, 28 Apr 2009, Stephen Rothwell wrote:
> > On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > > powerpc allmodconfig, current mainline:
> > > 
> > > drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> > > 
> > > switching it from __initconst to __initdata "fixes" it.
> > 
> > Interesting.  The program that generates the .c file above produces
> > __initdata for me ...
> 
> I assume Andrew once built in that tree using the recent logo patches that
>   1. Makes the logos const and switch them from __initdata to __initconst,
>   2. Fix the missing dependency of the generated files on the generator program.
> Hence if you revert the logo patches, you have to manually remove the generated
> files.
> 
> Is my assumption correct?

Nope - mrproper removes every .c file from drivers/video/logo/ apart
from logo.c



The failure is caused by your fbdev-move-logo-externs-to-header-file.patch.

Without that patch, drivers/video/logo/logo_linux_mono.c is generated as

	static unsigned char logo_linux_mono_data[] __initdata = {
	
and with that patch, drivers/video/logo/logo_linux_mono.c is generated as

	static const unsigned char logo_linux_mono_data[] __initconst = {

and it's the switch from __initdata to __initconst which causes this
section conflict in my setup.

Re: drivers/video/logo/logo_linux_mono.c build error

[Geert Uytterhoeven]

On Wed, 13 May 2009, Andrew Morton wrote:
> On Tue, 28 Apr 2009 09:24:53 +0200 (CEST)
> Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> > On Tue, 28 Apr 2009, Stephen Rothwell wrote:
> > > On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > powerpc allmodconfig, current mainline:
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > > 
> > > > drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> > > > 
> > > > switching it from __initconst to __initdata "fixes" it.
> > > 
> > > Interesting.  The program that generates the .c file above produces
> > > __initdata for me ...
> > 
> > I assume Andrew once built in that tree using the recent logo patches that
> >   1. Makes the logos const and switch them from __initdata to __initconst,
> >   2. Fix the missing dependency of the generated files on the generator program.
> > Hence if you revert the logo patches, you have to manually remove the generated
> > files.
> > 
> > Is my assumption correct?
> 
> Nope - mrproper removes every .c file from drivers/video/logo/ apart
> from logo.c
> 
> 
> 
> The failure is caused by your fbdev-move-logo-externs-to-header-file.patch.

Which is not in current mainline, so the above reference was incorrectly
fueling my assumption?

> Without that patch, drivers/video/logo/logo_linux_mono.c is generated as
> 
> 	static unsigned char logo_linux_mono_data[] __initdata = {
> 	
> and with that patch, drivers/video/logo/logo_linux_mono.c is generated as
> 
> 	static const unsigned char logo_linux_mono_data[] __initconst = {
> 
> and it's the switch from __initdata to __initconst which causes this
> section conflict in my setup.

But logo_linux_mono_data is referenced by 

    const struct linux_logo logo_linux_mono __initconst = { 
	    .type           = LINUX_LOGO_MONO,
	    .width          = 80,
	    .height         = 80,
	    .data           = logo_linux_mono_data
    };      

only, which is also __initconst? Where does the section type conflict come
from?

With kind regards,

Geert Uytterhoeven
Software Architect
Techsoft Centre

Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

Re: drivers/video/logo/logo_linux_mono.c build error

[Geert Uytterhoeven]

	Hi Andrew,

On Thu, 14 May 2009, Geert Uytterhoeven wrote:
> On Wed, 13 May 2009, Andrew Morton wrote:
> > On Tue, 28 Apr 2009 09:24:53 +0200 (CEST)
> > Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> > > On Tue, 28 Apr 2009, Stephen Rothwell wrote:
> > > > On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > > powerpc allmodconfig, current mainline:
>         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > > > 
> > > > > drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> > > > > 
> > > > > switching it from __initconst to __initdata "fixes" it.
> > > > 
> > > > Interesting.  The program that generates the .c file above produces
> > > > __initdata for me ...
> > > 
> > > I assume Andrew once built in that tree using the recent logo patches that
> > >   1. Makes the logos const and switch them from __initdata to __initconst,
> > >   2. Fix the missing dependency of the generated files on the generator program.
> > > Hence if you revert the logo patches, you have to manually remove the generated
> > > files.
> > > 
> > > Is my assumption correct?
> > 
> > Nope - mrproper removes every .c file from drivers/video/logo/ apart
> > from logo.c
> > 
> > 
> > 
> > The failure is caused by your fbdev-move-logo-externs-to-header-file.patch.
> 
> Which is not in current mainline, so the above reference was incorrectly
> fueling my assumption?
> 
> > Without that patch, drivers/video/logo/logo_linux_mono.c is generated as
> > 
> > 	static unsigned char logo_linux_mono_data[] __initdata = {
> > 	
> > and with that patch, drivers/video/logo/logo_linux_mono.c is generated as
> > 
> > 	static const unsigned char logo_linux_mono_data[] __initconst = {
> > 
> > and it's the switch from __initdata to __initconst which causes this
> > section conflict in my setup.
> 
> But logo_linux_mono_data is referenced by 
> 
>     const struct linux_logo logo_linux_mono __initconst = { 
> 	    .type           = LINUX_LOGO_MONO,
> 	    .width          = 80,
> 	    .height         = 80,
> 	    .data           = logo_linux_mono_data
>     };      
> 
> only, which is also __initconst? Where does the section type conflict come
> from?

Do you have any follow-up info on this one?

Thx!

With kind regards,

Geert Uytterhoeven
Software Architect
Techsoft Centre

Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

Re: drivers/video/logo/logo_linux_mono.c build error

[Andrew Morton]

On Tue, 26 May 2009 13:52:34 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:

> > But logo_linux_mono_data is referenced by 
> > 
> >     const struct linux_logo logo_linux_mono __initconst = { 
> > 	    .type           = LINUX_LOGO_MONO,
> > 	    .width          = 80,
> > 	    .height         = 80,
> > 	    .data           = logo_linux_mono_data
> >     };      
> > 
> > only, which is also __initconst? Where does the section type conflict come
> > from?
> 
> Do you have any follow-up info on this one?

Nope, sorry.  I've been offline for over a week and I only build
powerpc kernels occasionally.

If it's still there, I'll hit it again and I'll take a closer look.