* [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
@ 2020-01-01 18:32 bugzilla-daemon
2020-01-01 18:33 ` [Bug 206049] " bugzilla-daemon
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-01 18:32 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
Bug ID: 206049
Summary: alg: skcipher: p8_aes_xts encryption unexpectedly
succeeded on test vector "random: len=0 klen=64";
expected_error=-22, cfg="random: inplace may_sleep
use_finup src_divs=[<flush>66.99%@+10,
33.1%@alignmask+1155]
Product: Platform Specific/Hardware
Version: 2.5
Kernel Version: 5.4.7
Hardware: PPC-64
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: PPC-64
Assignee: platform_ppc-64@kernel-bugs.osdl.org
Reporter: erhard_f@mailbox.org
Regression: No
Created attachment 286557
--> https://bugzilla.kernel.org/attachment.cgi?id=286557&action=edit
dmesg (5.4.7, Talos II)
# dmesg | grep -i aes
[ 5.589319] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on
test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace
may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]"
# inxi -b
System: Kernel: 5.4.7-gentoo ppc64 bits: 64 Console: tty 1 Distro: Gentoo
Base System release 2.6
Machine: Type: PowerPC Device System: T2P9D01 REV 1.01 details: PowerNV
T2P9D01 REV 1.01 rev: 2.2 (pvr 004e 1202)
CPU: 32-Core: POWER9 altivec supported type: MCP speed: 2785 MHz min/max:
2154/3800 MHz
Graphics: Device-1: Advanced Micro Devices [AMD/ATI] Caicos [Radeon HD
6450/7450/8450 / R5 230 OEM] driver: radeon v: kernel
Device-2: ASPEED Graphics Family driver: N/A
Device-3: NVIDIA GK208B [GeForce GT 710] driver: N/A
Display: server: X.org 1.20.5 driver: radeon tty: 211x53
Message: Advanced graphics data unavailable in console for root.
Network: Device-1: Broadcom and subsidiaries NetXtreme BCM5719 Gigabit
Ethernet PCIe driver: tg3
Device-2: Broadcom and subsidiaries NetXtreme BCM5719 Gigabit
Ethernet PCIe driver: tg3
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
@ 2020-01-01 18:33 ` bugzilla-daemon
2020-01-07 2:55 ` bugzilla-daemon
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-01 18:33 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
--- Comment #1 from Erhard F. (erhard_f@mailbox.org) ---
Created attachment 286559
--> https://bugzilla.kernel.org/attachment.cgi?id=286559&action=edit
kernel .config (5.4.7, Talos II)
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
2020-01-01 18:33 ` [Bug 206049] " bugzilla-daemon
@ 2020-01-07 2:55 ` bugzilla-daemon
2020-01-07 11:03 ` bugzilla-daemon
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-07 2:55 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
Daniel Axtens (dja@axtens.net) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dja@axtens.net
--- Comment #2 from Daniel Axtens (dja@axtens.net) ---
Hi Erhard,
I'm having a look. Does this reproduce reliably/often? Or was it a one-off?
Regards,
Daniel
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
2020-01-01 18:33 ` [Bug 206049] " bugzilla-daemon
2020-01-07 2:55 ` bugzilla-daemon
@ 2020-01-07 11:03 ` bugzilla-daemon
2020-01-07 11:03 ` bugzilla-daemon
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-07 11:03 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
Michael Ellerman (michael@ellerman.id.au) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |michael@ellerman.id.au
--- Comment #3 from Michael Ellerman (michael@ellerman.id.au) ---
Looks like other implementations check the size, can you try this:
diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c
index d59e736882f6..9fee1b1532a4 100644
--- a/drivers/crypto/vmx/aes_xts.c
+++ b/drivers/crypto/vmx/aes_xts.c
@@ -84,6 +84,9 @@ static int p8_aes_xts_crypt(struct skcipher_request *req, int
enc)
u8 tweak[AES_BLOCK_SIZE];
int ret;
+ if (req->cryptlen < AES_BLOCK_SIZE)
+ return -EINVAL;
+
if (!crypto_simd_usable() || (req->cryptlen % XTS_BLOCK_SIZE) != 0) {
struct skcipher_request *subreq = skcipher_request_ctx(req);
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
` (2 preceding siblings ...)
2020-01-07 11:03 ` bugzilla-daemon
@ 2020-01-07 11:03 ` bugzilla-daemon
2020-01-07 11:58 ` bugzilla-daemon
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-07 11:03 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
Michael Ellerman (michael@ellerman.id.au) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEEDINFO
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
` (3 preceding siblings ...)
2020-01-07 11:03 ` bugzilla-daemon
@ 2020-01-07 11:58 ` bugzilla-daemon
2020-01-07 23:02 ` bugzilla-daemon
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-07 11:58 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
--- Comment #4 from Erhard F. (erhard_f@mailbox.org) ---
(In reply to Daniel Axtens from comment #2)
> Hi Erhard,
>
> I'm having a look. Does this reproduce reliably/often? Or was it a one-off?
Hi Daniel,
This shows up every time booting the Talos II. I have yet to try Michaels
patch.
Regards,
Erhard
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
` (4 preceding siblings ...)
2020-01-07 11:58 ` bugzilla-daemon
@ 2020-01-07 23:02 ` bugzilla-daemon
2020-01-08 5:14 ` bugzilla-daemon
2020-01-08 23:19 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-07 23:02 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
--- Comment #5 from Erhard F. (erhard_f@mailbox.org) ---
(In reply to Michael Ellerman from comment #3)
> Looks like other implementations check the size, can you try this:
>
> diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c
> index d59e736882f6..9fee1b1532a4 100644
> --- a/drivers/crypto/vmx/aes_xts.c
> +++ b/drivers/crypto/vmx/aes_xts.c
> @@ -84,6 +84,9 @@ static int p8_aes_xts_crypt(struct skcipher_request *req,
> int enc)
> u8 tweak[AES_BLOCK_SIZE];
> int ret;
>
> + if (req->cryptlen < AES_BLOCK_SIZE)
> + return -EINVAL;
> +
> if (!crypto_simd_usable() || (req->cryptlen % XTS_BLOCK_SIZE) != 0) {
> struct skcipher_request *subreq = skcipher_request_ctx(req);
Your patch fixed it, thanks! Applied it on top of kernel 5.4.8 and the
p8_aes_xts error did not show up in subsequent reboots.
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
` (5 preceding siblings ...)
2020-01-07 23:02 ` bugzilla-daemon
@ 2020-01-08 5:14 ` bugzilla-daemon
2020-01-08 23:19 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-08 5:14 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
--- Comment #6 from Daniel Axtens (dja@axtens.net) ---
Patch sent: https://patchwork.ozlabs.org/patch/1219350/
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 206049] alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155]
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
` (6 preceding siblings ...)
2020-01-08 5:14 ` bugzilla-daemon
@ 2020-01-08 23:19 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2020-01-08 23:19 UTC (permalink / raw)
To: linuxppc-dev
https://bugzilla.kernel.org/show_bug.cgi?id=206049
Michael Ellerman (michael@ellerman.id.au) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |CODE_FIX
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-08 23:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01 18:32 [Bug 206049] New: alg: skcipher: p8_aes_xts encryption unexpectedly succeeded on test vector "random: len=0 klen=64"; expected_error=-22, cfg="random: inplace may_sleep use_finup src_divs=[<flush>66.99%@+10, 33.1%@alignmask+1155] bugzilla-daemon
2020-01-01 18:33 ` [Bug 206049] " bugzilla-daemon
2020-01-07 2:55 ` bugzilla-daemon
2020-01-07 11:03 ` bugzilla-daemon
2020-01-07 11:03 ` bugzilla-daemon
2020-01-07 11:58 ` bugzilla-daemon
2020-01-07 23:02 ` bugzilla-daemon
2020-01-08 5:14 ` bugzilla-daemon
2020-01-08 23:19 ` bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).