LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Mathieu Malaterre <malat@debian.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac
Date: Fri, 14 Jun 2019 15:26:31 -0500
Message-ID: <d508cc9c-435f-4108-17ac-6db74640514c@lwfinger.net> (raw)
In-Reply-To: <20190614191532.GC27145@darkstar.musicnaut.iki.fi>

On 6/14/19 2:15 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Fri, Jun 14, 2019 at 09:24:16AM +0200, Mathieu Malaterre wrote:
>> On Thu, Jun 13, 2019 at 10:27 AM Christoph Hellwig <hch@lst.de> wrote:
>>> With the strict dma mask checking introduced with the switch to
>>> the generic DMA direct code common wifi chips on 32-bit powerbooks
>>> stopped working.  Add a 30-bit ZONE_DMA to the 32-bit pmac builds
>>> to allow them to reliably allocate dma coherent memory.
>>>
>>> Fixes: 65a21b71f948 ("powerpc/dma: remove dma_nommu_dma_supported")
>>> Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>> ---
>>>   arch/powerpc/include/asm/page.h         | 7 +++++++
>>>   arch/powerpc/mm/mem.c                   | 3 ++-
>>>   arch/powerpc/platforms/powermac/Kconfig | 1 +
>>>   3 files changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
>>> index b8286a2013b4..0d52f57fca04 100644
>>> --- a/arch/powerpc/include/asm/page.h
>>> +++ b/arch/powerpc/include/asm/page.h
>>> @@ -319,6 +319,13 @@ struct vm_area_struct;
>>>   #endif /* __ASSEMBLY__ */
>>>   #include <asm/slice.h>
>>>
>>> +/*
>>> + * Allow 30-bit DMA for very limited Broadcom wifi chips on many powerbooks.
>>
>> nit: would it be possible to mention explicit reference to b43-legacy.
>> Using b43 on my macmini g4 never showed those symptoms (using
>> 5.2.0-rc2+)
> 
> According to Wikipedia Mac mini G4 is limited to 1 GB RAM, so that's
> why you don't see the issue.

He wouldn't see it with b43. Those cards have 32-bit DMA.

Larry



  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13  8:24 Christoph Hellwig
2019-06-13 18:51 ` Larry Finger
2019-06-14  7:24 ` Mathieu Malaterre
2019-06-14 19:15   ` Aaro Koskinen
2019-06-14 20:26     ` Larry Finger [this message]
2019-06-14 19:02 ` Aaro Koskinen
2019-06-19 10:50 ` Christoph Hellwig
2019-06-19 12:32   ` Michael Ellerman
2019-06-19 13:31     ` Benjamin Herrenschmidt
2019-06-19 14:28       ` Mathieu Malaterre
2019-06-20 13:49       ` Michael Ellerman
2019-06-23 10:34 ` Michael Ellerman

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d508cc9c-435f-4108-17ac-6db74640514c@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=aaro.koskinen@iki.fi \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=malat@debian.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org linuxppc-dev@archiver.kernel.org
	public-inbox-index linuxppc-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox